Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364806 - [project] Replace StringBuffer by StringBuilder
Summary: [project] Replace StringBuffer by StringBuilder
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 4.0.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: M5   Edit
Assignee: OCL Inbox CLA
QA Contact: Ed Willink CLA
URL:
Whiteboard:
Keywords:
Depends on: 367705
Blocks:
  Show dependency tree
 
Reported: 2011-11-25 05:25 EST by Ed Willink CLA
Modified: 2013-05-20 11:36 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-11-25 05:25:44 EST 
StringBuffer  is synchronized, StringBuilder is not, therefore replace all usage of StringBuffer by StringBuilder unless there is a specific need for synchronization.
Comment 1 Ed Willink CLA 2012-01-02 09:18:51 EST 
Numerous local changes in examples/tests committed to bug 318092 branch, whih will be merged to master once I can build on Hudson again.

Additional changes to core/impact plugins await review in (the last commit to) bug/364806. A couple of minor APIs use StringBuffer. These cannot be changed, but could be duplicated; I don't think the duplication is justified.

Further changes in auto-generated code await a template change for bug 367705.
Comment 2 Axel Uhl CLA 2012-01-05 09:32:37 EST 
The branch for this bug mixes changes regarding the obvious StringBuffer-->StringBuilder with changes regarding the way how delegates are resolved and how their URIs are being handled. I don't see the connection with the StringBuilder changes and suggest to move the delegate stuff to a separate bug / branch and keep this branch's changes limited to the subject of this bug.
Comment 3 Axel Uhl CLA 2012-01-05 09:42:55 EST 
Sorry, my bad; had'n merged the latest origin/master into my local master... Now reviewing the right diff. All I see in the core bundles are StringBuffer-->StringBuilder diffs.

+1 for merge to master.
Comment 4 Ed Willink CLA 2012-01-05 16:38:11 EST 
Pushed to master for M5.
Comment 5 Ed Willink CLA 2013-05-20 11:36:10 EDT 
CLOSED after a year in the RESOLVED state.