Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364702 - [compare] Compare view stopped working for me
Summary: [compare] Compare view stopped working for me
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: 0.4 M1   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-24 06:05 EST by Szymon Brandys CLA
Modified: 2011-11-24 22:18 EST (History)
0 users

See Also:

Attachments
In-line compare good (1.94 KB, image/png)
2011-11-24 06:08 EST, Szymon Brandys CLA 		no flags Details
side-by-side editor bad :( (17.91 KB, image/png)
2011-11-24 06:09 EST, Szymon Brandys CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-11-24 06:05:26 EST 
When I open the compare view it makes two calls, one for the diff and another one for uris. The compare editor used to work when only a correct diff and the old uri was returned. The new & base uris were not required. So if the call for uris returned:
{"Base":"",
"Old":"location of the old content",
"New":""}
the compare view worked. Now it does not. On one side it shows some javascript, which is not related to my comparison. Libing, could you look at it soon?
Comment 1 Szymon Brandys CLA 2011-11-24 06:07:48 EST 
In-line compare view still works fine. I'm attaching pictures showing the problem.
Comment 2 Szymon Brandys CLA 2011-11-24 06:08:29 EST 
Created attachment 207471 [details]
In-line compare good
Comment 3 Szymon Brandys CLA 2011-11-24 06:09:28 EST 
Created attachment 207472 [details]
side-by-side editor bad :(
Comment 4 libing wang CLA 2011-11-24 10:31:26 EST 
I am doing compare widget re-structuring for accepting different options, I will check in code today and that will fix your issue.
Comment 5 libing wang CLA 2011-11-24 22:17:47 EST 
fixed wit h0a23264ab2779f85e53977832d6436ce8ec6cb09.
Please confirm.