Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364660 - Eclipse Indigo doesn't display icon decorations in navigator view
Summary: Eclipse Indigo doesn't display icon decorations in navigator view
Status: RESOLVED WONTFIX
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows 7
: P3 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
: 362209 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-23 17:20 EST by Missing name CLA
Modified: 2012-07-31 09:56 EDT (History)
6 users (show)

See Also:


Attachments
Project Explorer on Indigo (109.77 KB, image/png)
2011-11-30 15:07 EST, Missing name CLA
no flags Details
Project Explorer on Helios (110.46 KB, image/png)
2011-11-30 15:11 EST, Missing name CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name CLA 2011-11-23 17:20:15 EST
Build Identifier: 20110916-0149

Previous releases showed icon decorations in the Navigator as well as Package explorer (i.e. compiler error and warning decorations)

There is a previous closed bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=265009 where this feature's prior existence was questioned. 

Installing a pristine vanilla Eclipse Helios JEE and performing the steps to reproduce will prove this feature's prior existence. (I used Eclipse Java EE IDE for Web Developers. Version: Helios Release Build id: 20100617-1415 to reproduce-- MD5 on the archive is 4d4f5104494b19435b5d826a8b76900f *eclipse-jee-helios-win32.zip)

Reproducible: Always

Steps to Reproduce:
1. Install Eclipse Indigo JEE SR1
2. Create Java Project
3. Create a class with an error in it
4. Notice no decorations in navigator while decorations do appear in package explorer.
Comment 1 Remy Suen CLA 2011-11-23 18:32:54 EST
I presume the feature is missing in both Helios Eclipse Classic and Indigo Eclipse Classic?
Comment 2 Dani Megert CLA 2011-11-24 03:05:23 EST
The Eclipse SDK never showed decorators (see bug 2108) and this won't change.

AFAIK WTP added them at some point and now this seems broken.
Comment 3 Missing name CLA 2011-11-24 16:52:25 EST
Thanks for the clarification. It is a useful feature which I have grown to depend on. I'm having difficulty finding the best place to report this bug. Any suggestions?
Comment 4 Nitin Dahyabhai CLA 2011-11-29 17:21:55 EST
It's the "Problem Marker Resource Decorator" from org.eclipse.jst.j2ee.navigator.ui in Helios, removed to fix bug 291498.
Comment 5 Missing name CLA 2011-11-30 14:32:15 EST
(In reply to comment #4)
> It's the "Problem Marker Resource Decorator" from
> org.eclipse.jst.j2ee.navigator.ui in Helios, removed to fix bug 291498.

The rabbit hole runs deep here. Working with maven projects in project explorer, the decorators are present on the folders in the "folder tree" section, but missing from the .java files themselves.

Is the plan to move the decorators back?
Comment 6 Remy Suen CLA 2011-11-30 14:33:40 EST
(In reply to comment #5)
> The rabbit hole runs deep here. Working with maven projects in project
> explorer, the decorators are present on the folders in the "folder tree"
> section, but missing from the .java files themselves.

Please provide a screenshot.
Comment 7 Greg Amerson CLA 2011-11-30 14:40:31 EST
I've noticed this problem on all resources even in the package explorer.  So when you have a WTP build validation marker on an XML file, you will see it on the parent folder but not on the resource.
Comment 8 Nitin Dahyabhai CLA 2011-11-30 15:01:20 EST
Comment 5 and comment 7 sound like a different problem--assuming they're experienced on Indigo.
Comment 9 Missing name CLA 2011-11-30 15:07:11 EST
Created attachment 207756 [details]
Project Explorer on Indigo

Notice no decorator on Foo.java
Comment 10 Missing name CLA 2011-11-30 15:11:06 EST
Created attachment 207757 [details]
Project Explorer on Helios

Notice the decorator on Bar.java
Comment 11 Missing name CLA 2011-11-30 15:11:49 EST
Comment on attachment 207756 [details]
Project Explorer on Indigo

er... Bar.java :)
Comment 12 Iger CLA 2011-12-07 06:05:10 EST
I've tried substituting org.eclipse.jst.j2ee.navigator.ui_1.1.501.v201107261503.jar and
org.eclipse.ui.navigator_3.5.100.v20110809-2227.jar content with the content of the relevant jars from the 3.7.0 release, and after some hiccuping (and resetting) of the perspectives, Eclipse seems to be up and running and the decorations are back.
Comment 13 Nitin Dahyabhai CLA 2011-12-07 12:23:00 EST
Dimitar, as this (at least as originally reported) is the result of fixing bug 291498, should it be resolved as wontfix (working as intended)?
Comment 14 Dimitar Giormov CLA 2011-12-08 02:57:46 EST
Thanks Nitin, you are right.

A little bit of explanation here. Having the decorations in navigator in Eclipse prior to Indigo SR1 was caused by using a wrong class as a problem decorator in java ee plugins. Further more the decorations were available only in Java EE distribution of eclipse (because of the location where the problem decorator definition was).

You can check for more details here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=291498

So what can you do now:
You can open a separate enhancement bug for the platform if you want to see problem markers in the navigator.

About the error markers on the xml I think the right component should be common validation in WTP

Best regards,
Dimitar
Comment 15 Remy Suen CLA 2011-12-08 07:34:22 EST
(In reply to comment #14)
> So what can you do now:
> You can open a separate enhancement bug for the platform if you want to see
> problem markers in the navigator.

That would be bug 2108. As per comment 3, note that the 'Navigator' view is no longer actively worked on and we, the Platform UI team, have no plans to add new features to that view.
Comment 16 Nitin Dahyabhai CLA 2011-12-08 07:55:21 EST
(In reply to comment #14)
> About the error markers on the xml I think the right component should be common
> validation in WTP

Comment 5 made reference to the same behavior on a .java file.  There must be another decorator at play.
Comment 17 ecdragon CLA 2011-12-11 16:03:22 EST
(In reply to comment #15)
> 
> That would be bug 2108. As per comment 3, note that the 'Navigator' view is no
> longer actively worked on and we, the Platform UI team, have no plans to add
> new features to that view.

Ouch. I have relied on the Navigator view (I never use the Project Explorer for various reasons) every day for years to do Java web app development. I'm flabbergasted. 

Surely I'm not the only engineer who prefers it to the Project Explorer?

What are my options? Do I have the option of contributing to Eclipse and maintaining that view myself?
Comment 18 Dani Megert CLA 2011-12-12 02:05:19 EST
(In reply to comment #17)
> (In reply to comment #15)
> > 
> > That would be bug 2108. As per comment 3, note that the 'Navigator' view is no
> > longer actively worked on and we, the Platform UI team, have no plans to add
> > new features to that view.
> 
> Ouch. I have relied on the Navigator view (I never use the Project Explorer for
> various reasons) every day for years to do Java web app development. I'm
> flabbergasted. 
> 
> Surely I'm not the only engineer who prefers it to the Project Explorer?
> 
> What are my options?
Try the Package Explorer.
Comment 19 Missing name CLA 2011-12-12 10:49:36 EST
(In reply to comment #17)
> (In reply to comment #15)
> > 
> > That would be bug 2108. As per comment 3, note that the 'Navigator' view is no
> > longer actively worked on and we, the Platform UI team, have no plans to add
> > new features to that view.
> 
> Ouch. I have relied on the Navigator view (I never use the Project Explorer for
> various reasons) every day for years to do Java web app development. I'm
> flabbergasted. 
> 
> Surely I'm not the only engineer who prefers it to the Project Explorer?
> 
> What are my options? Do I have the option of contributing to Eclipse and
> maintaining that view myself?

Clearly I'm in the same boat. The suggestion I've received from folks is to simply rally the community around the feature's restoration by creating an enhancement bug report. Have your fellow engineers who have come to rely on the navigator vote for this issue. Just because it gets 1000 votes doesn't mean it will be restored, but there is a far better chance to influence the process through community response.
Comment 20 Paul Webster CLA 2011-12-13 09:49:30 EST
(In reply to comment #17)
> Surely I'm not the only engineer who prefers it to the Project Explorer?
> 
> What are my options? Do I have the option of contributing to Eclipse and
> maintaining that view myself?

There's prefer, and there's maintainable.  We walked away from the ResourceNavigator >3 years ago.

As for options.  1) Use the Project Explorer, and vote for the last of the functionality that's missing (easily creating filters was one, I believe).  Or contribute it, if you were considering hacking the ResourceNavigator.

2) use the Package Explorer

Both the Project Explorer and Package Explorer are in the current development streams.

3) The ResourceNavigator code is still available, it's in /org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourceNavigator.java.  As it is, we wouldn't consider changing that in org.eclipse.ui.ide in 3.x.

But, you could try and refactor it into its own bundle, org.eclipse.ui.views.navigator, and then enhance it there.   See http://wiki.eclipse.org/Platform_UI/How_to_Contribute for information on getting a hold of the Platform UI git repos (they're also available from http://github.com/eclipse ).  There is a large learning curve here, though, as it is API and has to maintain behaviour.


PW
Comment 21 Nitin Dahyabhai CLA 2012-07-31 09:56:48 EDT
*** Bug 362209 has been marked as a duplicate of this bug. ***