364656 – SapphireDiagramEditor should not mark editor dirty when handling node update event. Model changes on the node will trigger that

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364656 - SapphireDiagramEditor should not mark editor dirty when handling node update event. Model changes on the node will trigger that

Summary: SapphireDiagramEditor should not mark editor dirty when handling node update ...

Status:	CLOSED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Sapphire (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Shenxue Zhou
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-11-23 16:58 EST by Shenxue Zhou
Modified:	2021-11-19 09:22 EST (History)
CC List:	2 users (show)

See Also:

Attachments
don't mark editor dirty on node update event. (794 bytes, patch) 2011-11-23 17:09 EST, Shenxue Zhou	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Shenxue Zhou

2011-11-23 16:58:28 EST

Comment 1 Konstantin Komissarchik

2011-11-23 17:04:17 EST

Please attach a patch for review before committing since we are now in the shutdown phase.

Comment 2 Shenxue Zhou

2011-11-23 17:07:14 EST

It's actually not a derived property issue. When node update event reaches SapphireDiagramEditor, it doesn't need to explicitly mark the editor dirty. If model change happens, it'll mark the editor dirty.

Comment 3 Shenxue Zhou

2011-11-23 17:09:57 EST

Created attachment 207449 [details]
don't mark editor dirty on node update event.

Comment 4 Konstantin Komissarchik

2011-11-23 17:15:34 EST

Ok. Go ahead.

Comment 5 Shenxue Zhou

2011-11-23 17:21:44 EST

Patch submitted.

Comment 6 Konstantin Komissarchik

2011-11-23 18:00:25 EST

Did you commit this to 0.4.x branch? If you put this only in HEAD, it will not be in the 0.4 release.

Comment 7 Shenxue Zhou

2011-11-23 18:05:57 EST

(In reply to comment #6)
> Did you commit this to 0.4.x branch? If you put this only in HEAD, it will not
> be in the 0.4 release.

I just resubmitted it to 0.4.x branch. Good catch. Thanks!

Comment 8 Raj Alagumalai

2011-11-28 14:17:21 EST

verified with 0.4.0.201111231805

Comment 9 Konstantin Komissarchik

2011-11-28 14:22:16 EST

Closing.