Comment 1 Krum Tsvetkov 2012-02-14 02:55:46 EST

Comment on attachment 207380 [details]
Proposed patch to be able to explicitly set pie slice colors

Thanks for the patch!
I reviewed and tested it. It looks fine.
I've submitted the changes as they are, only adjusted the copyright headers in the three files

Comment 2 Krum Tsvetkov 2012-02-14 02:57:29 EST

As the patch is now applied (SVN revision 1277) I am closing the bug.
Thanks again.

Comment 3 Kevin Grigorenko 2012-02-14 11:03:27 EST

Thanks!

Comment 4 Krum Tsvetkov 2012-03-01 10:32:17 EST

Kevin, the changes from the patch introduced an incompatible API change. I haven't noticed this on time, as I had my API tooling not configured after changing my IDE :(
We'll need to make some changes to avoid this. You can watch bug 372002 for more details.

Comment 5 Kevin Grigorenko 2012-03-05 17:23:07 EST

(In reply to comment #4)
> Kevin, the changes from the patch introduced an incompatible API change. I
> haven't noticed this on time, as I had my API tooling not configured after
> changing my IDE :(
> We'll need to make some changes to avoid this. You can watch bug 372002 for
> more details.

Hey Krum, no worries at all. For my own knowledge, what caused the incompatibility? Was it because a method was added to IResultPie?

Comment 6 Krum Tsvetkov 2012-03-07 09:32:30 EST

(In reply to comment #5)
> Was it because a method was added to IResultPie?
Yes. It was the new method to the interface. There are some more details in bug 
bug 372002

BTW, I added some description how API tooling baseline can be setup for MAT:
http://wiki.eclipse.org/MemoryAnalyzer/Contributor_Reference#Configure_API_Tooling_Baseline