Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364504 - ValidationDemo in org.eclipse.edt.rui.samples_0.7.0 doesn't display all errors
Summary: ValidationDemo in org.eclipse.edt.rui.samples_0.7.0 doesn't display all errors
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Brian Svihovec CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-22 13:49 EST by broy2 CLA
Modified: 2017-02-23 14:14 EST (History)
2 users (show)

See Also:


Attachments
EDT (71.65 KB, image/png)
2011-11-22 13:49 EST, broy2 CLA
no flags Details
RBD (82.02 KB, image/png)
2011-11-22 13:50 EST, broy2 CLA
no flags Details
Screen shot (76.62 KB, image/png)
2011-11-29 15:57 EST, broy2 CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description broy2 CLA 2011-11-22 13:49:50 EST
Created attachment 207378 [details]
EDT

Open gallery.validation.ValidationDemo in org.eclipse.edt.rui.samples_0.7.0.
Preview.
Click Submit.
There should be 8 errors, but there are only 2.
Screen shots of RBD and EDT attached.
Comment 1 broy2 CLA 2011-11-22 13:50:14 EST
Created attachment 207379 [details]
RBD
Comment 2 Jing Qian CLA 2011-11-22 15:03:44 EST
we don't support dataitem in 070, also we don't support custom message properties.

So the sample should be modified

change the record definition
any field that is dataitem type should be changed to primitive and its validation annotation should be added for it. 

i.e. 



record accountRecord
	username string { MinimumInput=6, MinimumInputMsgKey = "usrMinInput", validationPropertiesLibrary=ValidationMessages };
	password string { MinimumInput = 8, MinimumInputMsgKey = "pwMinInput", validationPropertiesLibrary=ValidationMessages };
	email string;
	firstName String {inputRequired = yes};
	lastName String {inputRequired = yes};
	birthday date { dateFormat="MM/dd/yy", TypeChkMsgKey = "invalidDate", validationPropertiesLibrary=ValidationMessages };
	address String {inputRequired = yes};
	city String {inputRequired = yes};
	state String {inputRequired = yes, uppercase = yes };
	zip int{@isDecimalDigit, typeChkMsgKey = "validZip", validationPropertiesLibrary=ValidationMessages};
end
Comment 3 Brian Svihovec CLA 2011-11-29 14:10:11 EST
Removed usage of the Data item for now.  I left in the data item for future use, and added a comment about why it is not being used in this release.

Note that the error messages are still the default messages, since validationPropertiesLibrary is not supported in the .7 release.  I have added this note in the code as well.
Comment 4 broy2 CLA 2011-11-29 15:51:32 EST
Verified, but looks really tacky.
Screen shot attached.
Comment 5 broy2 CLA 2011-11-29 15:57:54 EST
Created attachment 207690 [details]
Screen shot