Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364475 - allow customization of p2.inf requirement processing
Summary: allow customization of p2.inf requirement processing
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.8.0 Juno   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Juno M5   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351842
  Show dependency tree
 
Reported: 2011-11-22 10:10 EST by Igor Fedorenko CLA
Modified: 2011-12-12 06:56 EST (History)
2 users (show)

See Also:

Attachments
proposed changes (2.62 KB, application/octet-stream)
2011-11-22 10:10 EST, Igor Fedorenko CLA 		no flags Details
original patch in diff format (2.15 KB, patch)
2011-12-02 16:07 EST, Igor Fedorenko CLA 		dj.houghton: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2011-11-22 10:10:44 EST 
Created attachment 207367 [details]
proposed changes

To properly support optional dependencies in Tycho, it is necessary to be able to customize processing of p2.inf requires entries. See bug 351842 for more information about the problem and the solution we are implementing. Attached are proposed changes.
Comment 1 Igor Fedorenko CLA 2011-12-02 16:07:07 EST 
Created attachment 207869 [details]
original patch in diff format

Set "Ignore leading path name segments" to 1 (one) to apply this diff using
Eclipse UI.
Comment 2 Jan Sievers CLA 2011-12-08 03:40:28 EST 
patch is basically a refactoring that allows to override for custom behaviour in subclasses of BundlesAction.
BundlesAction is API, so would the protected method become API then?
Comment 3 Jan Sievers CLA 2011-12-08 03:46:09 EST 
(In reply to comment #2)
> patch is basically a refactoring that allows to override for custom behaviour
> in subclasses of BundlesAction.
> BundlesAction is API, so would the protected method become API then?

actually no, package org/eclipse/equinox/p2/publisher/eclipse is only exported with x-friends.

so this does not introduce new API
Comment 4 DJ Houghton CLA 2011-12-08 16:03:02 EST 
Fixed in commit e7751bddbe2ec653d48da730f5411b839c4c0f5c.
Comment 5 Igor Fedorenko CLA 2011-12-09 10:58:25 EST 
I don't see commit e7751bddbe2ec653d48da730f5411b839c4c0f5c in rt.equinox.p2.git repository


http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=e7751bddbe2ec653d48da730f5411b839c4c0f5c
Comment 6 DJ Houghton CLA 2011-12-09 11:01:03 EST 
I have it (and your other changes) locally and will push it once M4 is declared. Didn't want to push it to master in case we need a rebuild.
Comment 7 DJ Houghton CLA 2011-12-12 06:56:35 EST 
Ok, M4 was declared so I pushed the changes this morning for Bug 364221, Bug 364222, and Bug 364475.

Bug 364781 requires more investigation and discussion can happen there.