Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364466 - Two additional packages have to be added to the web application's Manifest file during transformation phase
Summary: Two additional packages have to be added to the web application's Manifest fi...
Status: CLOSED FIXED
Alias: None
Product: Gemini.Web
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.1.0.M02   Edit
Assignee: Violeta Georgieva CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-22 09:24 EST by Violeta Georgieva CLA
Modified: 2012-02-19 06:12 EST (History)
1 user (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2011-11-22 09:24 EST, Violeta Georgieva CLA 		glyn.normington: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Violeta Georgieva CLA 2011-11-22 09:24:06 EST 
Created attachment 207360 [details]
Patch

In Servlet API 3.0 there are two new packages:
- javax.servlet.annotation
- javax.servlet.descriptor

I would like to add them to DefaultsWebBundleManifestTransformer. We add servlet and jsp packages to the web application's Manifest file during transformation phase.

I am using version 2.6 for these packages because of the discussion in Bug 360245, thus we will be OK with both versions 2.6 and 3.0.

Could you please review that change.
Thanks
Violeta
Comment 1 Glyn Normington CLA 2011-11-22 10:05:04 EST 
Comment on attachment 207360 [details]
Patch

Looks good.
Comment 2 Violeta Georgieva CLA 2011-11-23 08:23:04 EST 
Change is tested, committed and pushed.
Commit Id: b64586cb0158cfe19fcb028487149281e6d065e2