Community
Participate
Working Groups
Open dojo.samples.perwidget.DojoGridSample in org.eclipse.edt.rui.dojo.samples_0.7.0. Preview. Click Symbol or Shares to sort the column and it sorts. Click the X or Price to sort and nothing happens.
This sounds like a duplicate of Bug 364361 - Sort on header of DataGrid doesn't work in org.eclipse.edt.rui.samples_0.7.0.
Brenda says this is a regression of EDT, because out of the 4 columns, they all used to be able to sort. Now only 2 columns are sorted right.
I'd be surprised if the is a duplicate since one is a RUI widget and the other is a Dojo widget. And in the Dojo widget, 2 of the columns sort and 2 don't.
Created attachment 207342 [details] Fix Reason: Pretty the same as 364361 This problem is caused by JavaScript Gen Change. The data is any[] type in DojoGrid. The elements in the data array will be boxed to any type while in RBD it is not. So the js of the sort function must add unboxAny to the array element. I have changed the DojoGrid when making the js change but miss some part of it when adding behavior, so there is error when addEditor behavior was sorted. Risk: This fix only affects DojoGrid widget when applying sorting in a editor behavior column. Customer Impact: If not fix, DojoGrid cannot be sorted when the column has editor behavior. Testcase: The Dojo Sample, Drag & drop a DojoGrid and do the sorting.
Change fix to egl.unboxAny(eglWidget.data[i])[eglWidget.columns[col].name] = items[i][eglWidget.columns[col].name][0]; Reviewed by Brian. Commit the code
JiYong, have you run the regression test against Eunit? Since this is caused by javascript gen fixes. Adding PengFei, please send daily report of Eunit results for java and javascript, to be sure there is no regression
Verified in 20111122 build.
