Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364352 - Launching inner Eclipse instance is broken on Mac
Summary: Launching inner Eclipse instance is broken on Mac
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 4.2 M4   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-21 10:09 EST by Oleg Besedin CLA
Modified: 2021-02-24 05:18 EST (History)
8 users (show)

See Also:

Attachments
Exception details (75.51 KB, text/rtf)
2011-11-21 10:09 EST, Oleg Besedin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2011-11-21 10:09:24 EST 
Created attachment 207309 [details]
Exception details

On Mac using current code from " org.eclipse.ui.cocoa" bundle launching inner instance results in the following exception:

Eclipse quit unexpectedly while using libswt-pi-coco-3811.jnilib plugin.

Invalid memory access of location 0x20 rip-0x7fff8297b6df

Attached file with exception details.
Comment 1 Oleg Besedin CLA 2011-11-21 10:18:41 EST 
The problem seems to be caused by this line in the CocoaUIEnhancer#init() :

	invokeMethod(OS.class, "objc_registerClassPair", makeArgs(cls));
Comment 2 Remy Suen CLA 2011-11-21 10:32:32 EST 
So it's safe to say this is a blocker, Oleg?
Comment 3 Oleg Besedin CLA 2011-11-21 11:04:56 EST 
The problem originates in the call to 

 objc_allocateClassPair(NSObject, "SWTCocoaEnhancerDelegate", 0)

in the same init() method. The call returns Nil indicating that the class with this name already exist. The Nil later passed to objc_registerClassPair() which, this time, triggers an exception.


(In reply to comment #2)
> So it's safe to say this is a blocker, Oleg?

This is certainly a blocker for me. I am not sure why it suddenly started to show up as this code has not being touched for at least a year. Could be that it was failing silently and recent Mac OS update changed it to surface a error.
Comment 4 Remy Suen CLA 2011-11-21 11:08:41 EST 
Oleg, what version is your OS X?
Comment 5 Brian de Alwis CLA 2011-11-21 11:12:25 EST 
It's true — org.eclipse.ui.cocoa is 3.x specific, and is not in the 4.x builds. It's been replaced by org.eclipse.e4.ui.workbench.renderers.swt.cocoa. org.eclipse.ui.cocoa should be deleted from master (providing we're not going to somehow merge the 3.x and 4.x branches into a single branch).  I meant to bring this up on last week's call.
Comment 6 Oleg Besedin CLA 2011-11-21 11:35:00 EST 
Thanks Brian!

So the only action items here is to delete "org.eclipse.ui.cocoa" from the master branch.

Paul, can you do that?
Comment 7 Paul Webster CLA 2011-11-21 12:02:49 EST 
I've deleted org.eclipse.ui.cocoa and org.eclipse.ui.carbon (not even supported anymore) from master, and pushed it.

PW
Comment 8 Oleg Besedin CLA 2011-11-21 13:23:53 EST 
(In reply to comment #7)
> I've deleted org.eclipse.ui.cocoa and org.eclipse.ui.carbon (not even supported
> anymore) from master, and pushed it.
> 
> PW

Thank you!
Comment 9 Paul Webster CLA 2011-12-06 14:13:45 EST 
Still fixed in I20111205-2330
PW
Comment 10 Markus Keller CLA 2014-04-16 08:48:33 EDT 
This broke file proxy icons, see bug 378723.