Community
Participate
Working Groups
bug 362591 comment# 10 has some changes to reduce console output while running junits for JDT/Core. As it was not directly pertinent to that bug, I did not release those changes for that bug fix. These changes need to considered on their own and released.
Ayush, please follow up. Check with Olivier if you need some explanation on the patch. Thanks for the patch Olivier.
When I first saw the new resource warnings in the test console I tried to fix this by adding close calls to the test verifier. This created mysterious failures on Olivier's windows box. X-ref: bug 359362 comment 3, partly reverted by commit eb6a62cd301dd92365462b5f4580a54624129ed5 In my experience it should suffice to alternatively just pass "-warn:-resource" to the command compiling the test verifier. I see this in Olivier's patch and just wonder if that's enough. On my box it had the desired effect, but maybe I'm missing yet more console output that is addressed by Olivier's additional changes?
(In reply to comment #2) [...] > In my experience it should suffice to alternatively just pass > "-warn:-resource" to the command compiling the test verifier. > > I see this in Olivier's patch and just wonder if that's enough. These two sentences above seems to be contradicting. To clarify, did you mean to say "... just wonder if that isn't enough." ? ^^^^^ > On my box it had the desired effect, but maybe I'm missing yet more > console output that is addressed by Olivier's additional changes? I presume, by this you are asking whether the changes over and above the "-warn:-resource" change have any effect at all. Ayush, please study this, so we can settle on the minimal change.
(In reply to comment #3) > (In reply to comment #2) > > [...] > > > In my experience it should suffice to alternatively just pass > > "-warn:-resource" to the command compiling the test verifier. > > > > I see this in Olivier's patch and just wonder if that's enough. > > These two sentences above seems to be contradicting. To clarify, > did you mean to say "... just wonder if that isn't enough." ? > ^^^^^ Sorry for imprecise language. I lean towards saying it is enough. > > On my box it had the desired effect, but maybe I'm missing yet more > > console output that is addressed by Olivier's additional changes? > > I presume, by this you are asking whether the changes over and above > the "-warn:-resource" change have any effect at all. Ayush, please > study this, so we can settle on the minimal change. Yes, that was exactly my intention.
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > Sorry for imprecise language. I lean towards saying it is enough. Actually, upon rereading my own rewording, I felt that it wasn't particularly unambiguous either. Anyways, we have squeezed out any potential ambiguity and Ayush should know precisely what is being talked about, so that is good :)
As Ayush is busy reviewing and testing the null annotations work, retargetting this to M5.
Note to self: While we're at it, we should also remove the couple of console messages coming from CompletionTestsRequestor2#canUseDiamond()
Postponed to M6.
Created attachment 210459 [details] proposed fix (In reply to comment #2) > I'm missing yet more > console output that is addressed by Olivier's additional changes? The additional changes are not directly related to the fix. Olivier mentioned that the org.eclipse.jdt.core.tests.util.TestVerifier.getVerifyTestsCode() should always contain the code for VerifyTests, and since that was not the case, he updated the string. The real fix is just adding -warn:-resource.
Released in master via commit f9060155e3cfd199faeec23a0a107fc22b1b0c9f
Verified for 3.8M6 using code inspection
