Community
Participate
Working Groups
Martin brought up in bug 354230 that there are some files with the word "cachegrind" in the filename in the helgrind.tests plugin. I can verify this is still the case: [org.eclipse.linuxtools.valgrind.helgrind.tests (master)]$ find -name *cachegrind* | wc -l 18 Do these just require a rename?
There are files that need rename and even removal. I intended to do a full cleanup of this plug-in while fixing the helgrind test plug-in & maven issue (https://bugs.eclipse.org/bugs/show_bug.cgi?id=350099) but, due to patch size > 250 lines, I was advised to not go along with the cleanup to avoid a legal review. I can do this cleanup of the plug-in files, absolutely, but the patch size will be way over 250 lines.
I think there was some mis-communication somewhere along the lines; sorry. If things need to be larger than 250 lines, then so be it. A legal review won't take forever and is required so let's go with that.
I will work in this cleanup.
I've done the cleanup but not I'm having a bit of trouble testing it. I'm running (current dir is linuxtools/valgrind): $ mvn -fae -X clean install and I've got the following error: [ERROR] Cannot resolve project dependencies: [ERROR] Software being installed: org.eclipse.linuxtools.valgrind.cachegrind 0.10.0.qualifier [ERROR] Missing requirement: org.eclipse.linuxtools.valgrind.core 0.10.0.qualifier requires 'bundle org.eclipse.linuxtools.tools.launch.core 0.0.0' but it could not be found [ERROR] Cannot satisfy dependency: org.eclipse.linuxtools.valgrind.cachegrind 0.10.0.qualifier depends on: package org.eclipse.linuxtools.valgrind.core 0.0.0 When trying to run from helgrind.tests directory, all tests gave the same error: "org.eclipse.core.runtime.CoreException: Valgrind integration has been disabled in Preferences" I've tried to put "runValgrind=yes" at pom.xml but the error persisted. Any ideas?
Jeff, have you had any problems with this recently? (Note that I think Jeff is off until Friday the 25th of November)
(In reply to comment #5) > Jeff, have you had any problems with this recently? > > (Note that I think Jeff is off until Friday the 25th of November) There was a patch to Valgrind from Otavio for the tools.la(In reply to comment #4) > I've done the cleanup but not I'm having a bit of trouble testing it. > > I'm running (current dir is linuxtools/valgrind): > > $ mvn -fae -X clean install > > and I've got the following error: > > > [ERROR] Cannot resolve project dependencies: > [ERROR] Software being installed: org.eclipse.linuxtools.valgrind.cachegrind > 0.10.0.qualifier > [ERROR] Missing requirement: org.eclipse.linuxtools.valgrind.core > 0.10.0.qualifier requires 'bundle org.eclipse.linuxtools.tools.launch.core > 0.0.0' but it could not be found > [ERROR] Cannot satisfy dependency: org.eclipse.linuxtools.valgrind.cachegrind > 0.10.0.qualifier depends on: package org.eclipse.linuxtools.valgrind.core 0.0.0 > I believe this is caused by you running clean from the valgrind directory. The valgrind plug-in in question requires something that is built in profiling (org.eclipse.linuxtools.tools.launch.core). If you do a clean, I believe that will clear the .m2 cache and then there is nothing in valgrind which tells it to build this required plug-in since that is in the profiling/pom.xml. You should run from the top-level directory. > > When trying to run from helgrind.tests directory, all tests gave the same > error: > > "org.eclipse.core.runtime.CoreException: Valgrind integration has been disabled > in Preferences" > > I've tried to put "runValgrind=yes" at pom.xml but the error persisted. > > Any ideas? Haven't seen this, but it may be related to the build not being run properly. Try running from the top level and add -Dmaven.test.failure.ignore=true to prevent other modules from stopping the build if they fail their tests since you are primarily interested in making the helgrind tests pass.
Hi, After the tips from Jeff I was able to build Linuxtools successfully, with all Helgrind tests plug-in passing the tests. I'm sending the patch. Note that, as said at the beginning of this thread, the patch exceeds 250 lines. And, for all legal purposes, I assert that the patch was done by me, I have legal clearance from IBM to contribute it and it is being contributed under the terms of the EPL.
Created attachment 207802 [details] Clean-up of the helgrind test plug-in.
It might make sense for Otavio to review this since he's also from IBM and could commit your patch without issue and following the Eclipse IP guidelines.
Committed in commit: 3bba668062dd0990a3631b414a215055ebbab565
