Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364162 - cancelling navigator dialogs leaves the navigator disabled
Summary: cancelling navigator dialogs leaves the navigator disabled
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-18 09:51 EST by Alvaro Sanchez-Leon CLA
Modified: 2012-01-24 17:46 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-11-18 09:51:07 EST
to reproduce:

* Try creating a brand new group, by populating the fields, 
* Then press cancel
* The navigator is diabled

Trying to close /re-open navigator enables the groups although no actions seem to work.
the toolbar remains disabled.
Comment 1 Alvaro Sanchez-Leon CLA 2011-11-18 10:23:41 EST
This applies to more than one dialog, 
all dialogs need to be validated

To get out of this, Eclipse needs to be restarted
Comment 2 Sebastien Dubois CLA 2011-11-18 16:29:00 EST
This is due to an error during the refactoringthat was done for Unit testing.

I reworked extensively the job/dialog handling to remove the previous solution (which was more of a hack) and I introduced a definitive solution to handle the Navigator view state handling in conjunction with dialog.  The current code is much more efficient and integrated than was we had before.

I also introduced a hard reset of the view at startup.  So if ever the users get stuck with a disabled Navigator view (which should not happen anymore :-), then closing and re-opening the view should reset it correctly.