Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364082 - [xbase] Remove dependency to JDT from xbase core bundle
Summary: [xbase] Remove dependency to JDT from xbase core bundle
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: M4   Edit
Assignee: Dennis Huebner CLA
QA Contact:
URL:
Whiteboard: v2.4.3
Keywords:
: 412368 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-17 14:51 EST by Sebastian Zarnekow CLA
Modified: 2017-10-31 10:57 EDT (History)
4 users (show)

See Also:
sebastian.zarnekow: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2011-11-17 14:51:11 EST 
The OnTheFlyCompiler in the xbase core that depends on jdt types but there is no client in that bundle for the compiler itself. We should consider to move the OnTheFlyCompiler to xbase.ui. Otherwise we may introduce other deps to jdt by accident (see bug 364077)
Comment 1 Sven Efftinge CLA 2011-11-17 14:54:46 EST 
It's a runtime thingy so UI doesn't fit well.
Comment 2 Sebastian Zarnekow CLA 2011-11-17 14:57:16 EST 
Yeah I know. xbase.ui is a bad name but it's the bundle were we create functionality that _depends_ on e.g. eclipse workspaces and the like. The compiler does not work without eclipse.resources
Comment 3 Sven Efftinge CLA 2011-11-17 15:11:05 EST 
The standalone compiler should be usable without the need for xbase.ui (or mylangauge.ui).
Today we added org.eclipse.xtext.xtend2.standalone which is the runtime compilation story for Xtend. But in fact we should support something like this for every base language. So maybe we should add a similar project for Xbase?

The OnTheFlyCompiler could go into ~.xbase.tests for now.
Comment 4 Sven Efftinge CLA 2011-11-17 15:12:31 EST 
that should have been "for every Xbase language"
Comment 5 Sebastian Zarnekow CLA 2011-11-17 15:26:48 EST 
(In reply to comment #3)
> The OnTheFlyCompiler could go into ~.xbase.tests for now.

+1 even though others already seem to use it.

For 2.3 we should really try to find a more reasonable split for runtime/equinox/ui (ui as in needs a display)
Comment 6 Sven Efftinge CLA 2011-11-21 05:56:11 EST 
I moved it to base.junit and removed the JDT sep from org.eclipse.xtext.xbase
Comment 7 Dennis Huebner CLA 2011-11-21 13:17:52 EST 
(In reply to comment #5)
> (In reply to comment #3)
> > The OnTheFlyCompiler could go into ~.xbase.tests for now.
> 
> +1 even though others already seem to use it.
> 
> For 2.3 we should really try to find a more reasonable split for
> runtime/equinox/ui (ui as in needs a display)

+2 for splitting in runtime/headless(equinox)/ui
Comment 8 Jan Koehnlein CLA 2013-07-05 03:32:44 EDT 
*** Bug 412368 has been marked as a duplicate of this bug. ***
Comment 9 Jan Koehnlein CLA 2013-07-05 03:33:06 EDT 
See bug 364082
Comment 10 Dennis Huebner CLA 2013-07-05 07:54:56 EDT 
(In reply to comment #9)
> See bug 364082
I see :)
You mean bug 412368 ?
Comment 11 Jan Koehnlein CLA 2013-07-05 07:58:57 EDT 
Yep.
Comment 12 Sebastian Zarnekow CLA 2013-07-08 09:00:37 EDT 
If we only use string constants, they will be inlined by the compiler anyway and the dependency can be marked as optional.
Comment 13 Jan Koehnlein CLA 2013-07-09 04:11:37 EDT 
Keeping the optional dependency bears the risk that we silently use more JDT functionality in the long run. If we skipped the dependency we could write a test making sure it is not reintroduced.
Comment 14 Dennis Huebner CLA 2013-07-09 05:21:42 EDT 
I confirm that only constants are used so we can make this dependency optional.
Comment 15 Dennis Huebner CLA 2013-07-09 07:58:27 EDT 
I've copied 7 constants from JavaCore class. So the jdt.core dependency is completely removed now.
Comment 16 Eclipse Webmaster CLA 2017-10-31 10:46:21 EDT 
Requested via bug 522520.

-M.
Comment 17 Eclipse Webmaster CLA 2017-10-31 10:57:35 EDT 
Requested via bug 522520.

-M.