Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364068 - Variable fails to be resolved in features folder for Target Platform definition
Summary: Variable fails to be resolved in features folder for Target Platform definition
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 365136 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-17 12:43 EST by Sébastien Gandon CLA
Modified: 2015-09-16 08:54 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Gandon CLA 2011-11-17 12:43:14 EST
Build Identifier: 3.7

We have a project (svn) that contains our target platform.
I'd like to define the PDE Target platform using variable to make the definition relative to the project.
Adding a folder using ${resource_loc} works fine but adding a feature using this variable fails.
see this screen shot : https://skitch.com/sgandon/gjp1b/edit-target-definition

Reproducible: Always
Comment 1 Sébastien Gandon CLA 2011-11-17 12:45:55 EST
When creating the feature, the editor reads the feature list correctly and displays all of them, then I select them all and click finish.
Then in the Target Content Dialog you have plenty of errors stating : unable to locate feature XXXX
Comment 2 Curtis Windatt CLA 2011-11-17 12:55:21 EST
The feature location uses directory locations with some code to filter out the unwanted features.  We are just missing a variable resolution somewhere.  A stack trace would be helpful, but the editor won't produce one in this case.
Comment 3 Curtis Windatt CLA 2011-11-22 14:55:16 EST
Fixed in master.  However, you can likely work around the issue by pointing your locations one directory higher (the parent folder of the features folder).  The problem wasn't that we were missing a variable resolve, instead the problem is that the PluginPathFinder always assumes there will be a features folder.  I changed the code to use the provided directory if no features folder or linked folders are found.

While working on this issue I uncovered a larger regression with how the UI handles features since the target API change.  We were in some places still passing around IFeatureModels instead of the new TargetFeature API.  The feature target location code still uses IFeatureModel and we use it internally inside TargetFeature, but everywhere else in the target framework we use TargetFeature.
Comment 4 Curtis Windatt CLA 2011-12-01 12:36:10 EST
*** Bug 365136 has been marked as a duplicate of this bug. ***
Comment 5 Curtis Windatt CLA 2011-12-06 17:40:34 EST
Tested the target platform UI heavily during today's milestone test pass.  Not seeing any problems with the feature management.  Verified in I20111206-1015