Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363956 - Remove unused code (<2.4.x) in Combo
Summary: Remove unused code (<2.4.x) in Combo
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2011-11-16 13:57 EST by Silenio Quarti CLA
Modified: 2011-12-09 11:07 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Silenio Quarti CLA 2011-11-16 13:57:56 EST 
Need to remove all the code in Combo that runs only when the version is less than 2.4.

This is to continue the work start in bug#360872 and bug#361004.
Comment 1 Silenio Quarti CLA 2011-11-16 14:05:36 EST 
Alexander, please could make these changes?

Also after all the unused code is removed, we should fix the indentation.
Comment 2 Alexander Kurtakov CLA 2011-11-16 14:28:21 EST 
Sure, I'll do it
Comment 3 Alexander Kurtakov CLA 2011-11-21 09:18:36 EST 
Here are the requested changes.
http://fedorapeople.org/gitweb?p=akurtakov/public_git/eclipse.platform.swt.git;a=commit;h=d6f1ad6388435d1b64a45c01d0e8cb19a8ec6e73
According to http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions it is fine to just point to the release but if you prefer to have patches let me know
Comment 4 Silenio Quarti CLA 2011-11-25 09:54:39 EST 
Pushed changes to git.eclipse.org
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5014eebfedd0f623cdc5c8c21ddc6fda2b771129

Thanks Alex.  Please put the bug number in your commit comments. It helps us track the bug associated to the changed. Usually we just copy the description above as the commit comment:

"Bug 363956 - Remove unused code (<2.4.x) in Combo"
Comment 5 Alexander Kurtakov CLA 2011-11-25 10:03:19 EST 
OK, will do. Though upto now I had a different workflow. Commit to my git repo and once I"m satisfied with the changes open bug report