Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363950 - Allow customization of bundle requirements generation
Summary: Allow customization of bundle requirements generation
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.8.0 Juno   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Juno M4   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351842
  Show dependency tree
 
Reported: 2011-11-16 13:40 EST by Igor Fedorenko CLA
Modified: 2011-11-21 22:38 EST (History)
3 users (show)

See Also:


Attachments
proposed changes to BundlesAction (7.05 KB, text/plain)
2011-11-16 13:40 EST, Igor Fedorenko CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2011-11-16 13:40:38 EST
Created attachment 207106 [details]
proposed changes to BundlesAction

It Tycho, we need a way to customize generation of bundle requirements to properly handle various scenarios involving optional resolution, see bug 351842 for more details. Proposed solution is to refactor BundlesAction to allow subclasses override handling of Import-Package and Require-Bundle.
Comment 1 DJ Houghton CLA 2011-11-17 17:08:50 EST
Igor, the attachment on this bug looks like an email containing a patch and I've tried to copy parts of the email and attach them as a patch, but it doesn't apply cleanly. Please attach a clean patch so we can look at it. Thanks.
Comment 2 Igor Fedorenko CLA 2011-11-17 17:15:46 EST
DJ, this is output of git-format-patch, it can be applied using git-am command. If you have curl installed, the following command should do the trick

curl https://bugs.eclipse.org/bugs/attachment.cgi?id=207106 | git am

I can provide patch in another format if you prefer, just let me know what tool(s) you want me to use for that.
Comment 3 DJ Houghton CLA 2011-11-21 14:08:21 EST
Normally I like patches in a form that Eclipse can deal with them so I can just copy and paste. But if this is a well-known format and is easier for you to add as an attachment, then I will try applying it from the command-line. I'm not sure if eGit already has an open feature request to accept this type of patch but if not, it would be a good feature to have.
Comment 4 Pascal Rapicault CLA 2011-11-21 22:38:31 EST
Patch released in HEAD. Should make next week integration.