Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363920 - The save on close ignores the "NO"
Summary: The save on close ignores the "NO"
Status: CLOSED NOT_ECLIPSE
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 10:03 EST by Yigal Spinner CLA
Modified: 2011-11-16 16:02 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yigal Spinner CLA 2011-11-16 10:03:27 EST 
Build Identifier: 20110218-0911

In the class org.eclipse.ui.internal.SaveablesList#preCloseParts()
When prompting to the user that the part is closing and asking what to do.
The code only checks if the user pressed cancel.  However if the user clocks on NO it will save the information since it is not cancel.
Need to either change the code of show in the message box only "Yes" and "Cancel"

Reproducible: Always

Steps to Reproduce:
1. Create any editor (EMF model edit is the easy one)
2. Run the project and create a model and save it.
3. Open the file and change the values with out saving the file.
4. click on X to close the editor.
5. a dialog box comes up with "Yes", "No" and "Cancel"
6. Press the "No" option.
7.  The changes are saved.