Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363910 - [Refactoring] The "Delete" menu from diagrams is disabled
Summary: [Refactoring] The "Delete" menu from diagrams is disabled
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Patrick Tessier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 359057
  Show dependency tree
 
Reported: 2011-11-16 09:28 EST by Camille Letavernier CLA
Modified: 2012-01-24 03:41 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Camille Letavernier CLA 2011-11-16 09:28:08 EST
In most UML Diagrams, it is not possible to delete an Element. The "Delete" command is always grayed.
Comment 1 Patrick Tessier CLA 2011-12-06 08:26:08 EST
The refactoring has introduces modofications in ID that were not impacted in the regular expression of the service Edit

So if the purpose was to say this service edit is applied on element without "diagram" word.
The regular expression is: 
"org\.eclipse\.papyrus\.uml\.[^d]|$|d([^i]|$)|di([^a]|$)|dia([^g]|$)|diag([^r]|$)|diagr([^a]|$)|diagra([^m]|$))"
to see more info :
http://yannesposito.com/Scratch/fr/blog/2010-02-15-All-but-something-regexp/

done in the revision 6354
Comment 2 Yann Tanguy CLA 2012-01-23 04:29:39 EST
The regexp is either incorrect or not supported by eclipse extension.

How has this been tested ? I'm currently modifying the oep.uml.service.types.tests to adapt to v0.9.0, so far it seems that various UML ElementTypes (that should be concerned by the regexp) are not correctly added to Papyrus context.

Did you ensure that the "delete" command (after this fix) had the expexted behavior ?
Comment 3 Yann Tanguy CLA 2012-01-24 03:41:10 EST
(In reply to comment #2)
> The regexp is either incorrect or not supported by eclipse extension.
> 
> How has this been tested ? I'm currently modifying the
> oep.uml.service.types.tests to adapt to v0.9.0, so far it seems that various UML
> ElementTypes (that should be concerned by the regexp) are not correctly added to
> Papyrus context.
> 
> Did you ensure that the "delete" command (after this fix) had the expexted
> behavior ?

I removed the regex pattern (cf. bug#369366), replaced by exhaustive element type ref declarations.