Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363889 - [MVC] The tool tip for DojoTime widget does not work correctly
Summary: [MVC] The tool tip for DojoTime widget does not work correctly
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Huang Ji Yong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 364494 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-15 22:22 EST by fahua jin CLA
Modified: 2017-02-23 14:20 EST (History)
6 users (show)

See Also:


Attachments
The sample project. (75.12 KB, application/x-zip-compressed)
2011-11-15 22:22 EST, fahua jin CLA
no flags Details
Fix (845 bytes, patch)
2011-11-23 01:08 EST, Huang Ji Yong CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fahua jin CLA 2011-11-15 22:22:20 EST
Build Identifier: 0.7.0.v201111150901

1) Open the ToolTipErrorMessageTest.egl with VE in attached project.
2) Click in the Dojo time box, the expected result would be show the tool-tip at the side of the Dojo time box. If click out of the Dojo time box, then the expected result would be hide the time selection list. 



Reproducible: Always
Comment 1 fahua jin CLA 2011-11-15 22:22:48 EST
Created attachment 207078 [details]
The sample project.
Comment 2 Justin Spadea CLA 2011-11-17 17:22:24 EST
This looks like a Dojo widget problem. The onFocusGained event in Controller.egl is not getting invoked; it looks like the Dojo widget is clobbering that event to do its popup.
Comment 3 Brian Svihovec CLA 2011-11-18 16:00:00 EST
Does this happen in RBD?
Comment 4 Brian Svihovec CLA 2011-11-18 16:04:42 EST
Generally I am thinking we will defer this until after .7.  If a review of the problem shows a completely obvious fix, attach it here and we can discuss.
Comment 5 Brian Svihovec CLA 2011-11-21 15:51:24 EST
This does not happen in RBD.
Comment 6 Brian Svihovec CLA 2011-11-21 20:50:25 EST
I tested this again in EDT today, and it seems to be working?  When I click in the Dojo time box, I get a tool tip to the right saying, "View level validation Failed!", and the time drop down appears.  When I click out of the box, both the tooltip and the drop down disappear.
Comment 7 Jing Qian CLA 2011-11-22 14:05:54 EST
the tooltip does not work on external FF browser, it works using the preview pane(IE) and external IE browser.
Comment 8 Jing Qian CLA 2011-11-22 15:14:50 EST
ok, it's the external IE8 and FF browser has this issue.

using the preivew (IE7, 8) and external IE7, the tooltip & the hide behaves correctly for timeTextBox.

Brian also checked RBD 8012, it does not have such issues with external IE8 & FF
Comment 9 Brian Svihovec CLA 2011-11-22 15:17:41 EST
EDT .7
* Internal IE8 - Clicking in the aTime field displays the time drop down and the tooltip.  Clicking elsewhere on the screen hides the tooltip and the time drop down.
* External IE8 - Clicking in the aTime field displays the time drop down but does NOT display the tooltip.  Clicking elsewhere on the screen does NOT hide the drop down.  Clicking in the aTime field again causes the time drop down to hide.
* External FF 3 - Same as External IE8

RBD 8.0.1.2
* Internal FF, External FF, and External IE8 - Clicking in the aTime field displays the time drop down and the tooltip.  Clicking elsewhere on the screen hides the tooltip and the time drop down.

NOTE: In RBD, there are two messages that can appear in the tool tip dialog.  The first message is an EGL CR Runtime message, and the second message is "View level validation failed".  The first message appears the first time the tooltip is displayed, and the second message appears all other times.  In EDT, there is only one message that appears in the tooltip dialog when the dialog is displayed, and that is "View level validation failed".  This may have to do with Bug 364366 - ValidationPropertiesLibrary needs to be supported.
Comment 10 Huang Ji Yong CLA 2011-11-23 01:08:51 EST
Created attachment 207399 [details]
Fix

Reason:
A regression of 360972 which only apply to non-IE browsers.
When DojoTimeTextBox does not specify an ID, a null ID will set to the Dojo widget Dom.
Risk:
The change is minor. May impact the DojoTimeTextBox widget.
Test:
The test case, d&d DojoTimeTextBox and set an ID, Dojo Sample
Comment 11 Brian Svihovec CLA 2011-11-23 21:30:00 EST
*** Bug 364494 has been marked as a duplicate of this bug. ***
Comment 12 Brian Svihovec CLA 2011-11-23 21:35:47 EST
Deferring until after .7.  Users will most likely not encounter this issue, and if they do they can set an ID on the widget to avoid this problem.
Comment 13 Huang Ji Yong CLA 2011-12-14 03:46:38 EST
Commit the fix
Comment 14 fahua jin CLA 2012-01-16 21:22:43 EST
Verified in 0.8.0.v201201150902-1CT-Fiv5_M5_LOPfUa4.