Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363841 - [jobs] Confusing "," at the end of rule stack in ThreadJob
Summary: [jobs] Confusing "," at the end of rule stack in ThreadJob
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 4.2.1   Edit
Assignee: Szymon Ptaszkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 10:52 EST by Szymon Ptaszkiewicz CLA
Modified: 2012-09-05 03:56 EDT (History)
1 user (show)

See Also:

Attachments
Patch (789 bytes, patch)
2011-11-15 10:52 EST, Szymon Ptaszkiewicz CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2011-11-15 10:52:42 EST 
Created attachment 207035 [details]
Patch

ThreadJob#toString shows ThreadJob(null,[A,B,C,]) which may indicate there is more than one rule on the stack. The last comma should be omitted so that it would look like this: ThreadJob(null,[A,B,C]).
Comment 1 Szymon Ptaszkiewicz CLA 2011-11-15 10:55:18 EST 
(In reply to comment #0)
> ThreadJob#toString shows ThreadJob(null,[A,B,C,]) which may indicate there is
> more than one rule on the stack.

Of course, it should be: "more than three rules".
Comment 2 Szymon Ptaszkiewicz CLA 2012-04-24 02:55:14 EDT 
Here is an example of confusing entry from .log:

!ENTRY org.eclipse.core.jobs 4 1 2011-10-26 14:23:06.078
!MESSAGE Worker thread ended job: root(45), but still holds rule: ThreadJob(root(45),[R/,])
Comment 4 John Arthorne CLA 2012-08-23 16:25:34 EDT 
We used the same branch for 4.1 M1 and 4.2.1, so these changes are actually in 4.2.1 as well.
Comment 5 Szymon Ptaszkiewicz CLA 2012-09-05 03:56:15 EDT 
Verified in M20120829-1200.