Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363834 - [Bidi] STextProcessor: Test failures testSomeMore, testSTextProcessor
Summary: [Bidi] STextProcessor: Test failures testSomeMore, testSTextProcessor
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Components (show other bugs)
Version: unspecified   Edit
Hardware: All Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: Juno M4   Edit
Assignee: equinox.components-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 09:50 EST by Oleg Besedin CLA
Modified: 2011-11-15 11:00 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2011-11-15 09:50:04 EST 
The tests fail because Mac OS is not listed in the supported operating systems, see STextEnvironment#isProcessingNeeded() :

boolean supportedOS = osName.startsWith("windows") || osName.startsWith("linux"); 

While the value of osName on the Mac is "mac os x".

If I add "|| osName.startsWith("mac")" tests pass.
Comment 1 Matitiahu Allouche CLA 2011-11-15 10:56:28 EST 
(In reply to comment #0)
> The tests fail because Mac OS is not listed in the supported operating systems,
> see STextEnvironment#isProcessingNeeded() :
> 
> boolean supportedOS = osName.startsWith("windows") ||
> osName.startsWith("linux"); 
> 
> While the value of osName on the Mac is "mac os x".
> 
> If I add "|| osName.startsWith("mac")" tests pass.

Please add the check for "mac os x". This does not mean that Mac OS supports bidi in general to the same extent as Windows or even Linux, but if all the SText tests pass, we can state that this component is supported on Mac OS.
Comment 2 Oleg Besedin CLA 2011-11-15 11:00:41 EST 
Done. Also the TextProcessor includes "mac" into the list.

http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=4fa68b899a09f5e72120fb8829bbdfc4d89f1473