Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363781 - [RBD] RUI CheckBox widget displays abnormal when DD out of default GridLayout
Summary: [RBD] RUI CheckBox widget displays abnormal when DD out of default GridLayout
Status: REOPENED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: pf yu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 04:10 EST by Thomas Wu CLA
Modified: 2017-02-23 14:19 EST (History)
5 users (show)

See Also:


Attachments
CheckBox displaying error (57.10 KB, image/pjpeg)
2011-11-15 04:12 EST, Thomas Wu CLA
no flags Details
The patch file. (1.11 KB, text/plain)
2011-12-16 02:34 EST, fahua jin CLA
no flags Details
Tested on 20120121 (6.90 KB, image/pjpeg)
2012-01-21 00:41 EST, Thomas Wu CLA
no flags Details
widget is split to 2 parts (21.15 KB, image/pjpeg)
2012-03-29 22:55 EDT, Thomas Wu CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wu CLA 2011-11-15 04:10:06 EST
Build Identifier: 20111114

There is the same issue in RBD, but I think it is High Severity and should be fixed in 0.7.
DD a rui CheckBox widget outside the defaul GridLayout, the widget displays abnormal.

Reproducible: Always

Steps to Reproduce:
1.DD a rui CheckBox widget outside the defaul GridLayout

Actual results: The CheckBox is seperated as two parts, and please refer to screenshot.
Comment 1 Thomas Wu CLA 2011-11-15 04:12:09 EST
Created attachment 207012 [details]
CheckBox displaying error
Comment 2 Brian Svihovec CLA 2011-11-15 09:31:31 EST
What browser is being used in RBD and EDT for the Design pane?
Comment 3 Thomas Wu CLA 2011-11-15 09:54:07 EST
I tried both IE and XULRunner, thanks.
Comment 4 Brian Svihovec CLA 2011-11-17 12:10:39 EST
I am deferring this because it has always existed and users have the Dojo Checkbox that works correctly if they need this behavior.  Any change to this widget at this point could break it in unexpected ways.
Comment 5 fahua jin CLA 2011-12-16 02:34:50 EST
Created attachment 208479 [details]
The patch file.
Comment 6 fahua jin CLA 2011-12-16 02:35:19 EST
Jimmy, please review the code, thanks.
Comment 7 Yun Feng Ma CLA 2011-12-16 03:31:11 EST
This patch is hardcoding the style of child widget, the style should be move to css file. Thanks.
Comment 8 fahua jin CLA 2011-12-19 00:28:17 EST
(In reply to comment #7)
> This patch is hardcoding the style of child widget, the style should be move to
> css file. Thanks.

Change
------------------------------------
.claro .EglRuiCheckBox input{
	width: 16px;
	height: 16px;
	margin-right: 2px;
}


to
------------------------------------
.claro .EglRuiCheckBox input{
	width: 16px;
	height: 16px;
	margin-right: 2px;
	vertical-align:top;
}
Comment 9 fahua jin CLA 2011-12-19 00:37:42 EST
Resolve the defect.
Comment 10 Thomas Wu CLA 2012-01-21 00:39:56 EST
This is partly fixed because the highlights in VE is still along with the checkbox widget. Please refer to screen shot.
Comment 11 Thomas Wu CLA 2012-01-21 00:41:18 EST
Created attachment 209870 [details]
Tested on 20120121
Comment 12 fahua jin CLA 2012-01-21 01:40:27 EST
It's a problem of VE. I tried below browser types. 

1) WebKit - it works fine.
2) XULRunner - refer to the picture attached by Thomas.
3) IE - the selection box is in the middle.

Also, since Forest is in vacation now, and I triage this defect to M2.
Comment 13 Huo Zhen Zhong CLA 2012-02-17 04:56:08 EST
This defect is assigned to me at the last day of I2, so no time to fix it in I2, suggest to move it to I3.
Comment 14 Huo Zhen Zhong CLA 2012-02-28 04:19:56 EST
Rocky's fix has some problem, the right fix should remove "vertical-align:top;" from ".claro .EglRuiCheckBox span":

.claro .EglRuiCheckBox span{
	/*vertical-align:top;*/
}

After apply the fix, there is a lot problem remain, that is when use IE 8 in VE, the border of checkbox will be little below the checkbox, that is known issue in 363259, which will not plan to be fix in near time because it is only occurs in IE 8.
Comment 15 Thomas Wu CLA 2012-03-29 22:51:53 EDT
I tried in build of 201203292102. The orignal issue reoccur both in FF and internal browser. The CheckBox is seperated as two parts again. So it is no related with IE now. Please refer to the screenshot.
Comment 16 Thomas Wu CLA 2012-03-29 22:55:33 EDT
Created attachment 213369 [details]
widget is split to 2 parts
Comment 17 Huo Zhen Zhong CLA 2012-03-30 04:09:44 EDT
There is no changes to solve it in 0.8, will try to solve it in 0.8.1