Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363697 - Clean Up in AbstractOutlineViewButton
Summary: Clean Up in AbstractOutlineViewButton
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 09:26 EST by Ralph Steiner CLA
Modified: 2021-08-19 11:13 EDT (History)
1 user (show)

See Also:
zimmermann: juno+


Attachments
Suggested Patch (2.21 KB, patch)
2011-11-14 09:26 EST, Ralph Steiner CLA
stephan.leichtvogt: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Steiner CLA 2011-11-14 09:26:38 EST
Created attachment 206947 [details]
Suggested Patch

The code in the class AbstractOutlineViewButton looks strange. There is a mix between a proptery m_desktop an the usage of ClientJob.getCurrentSession().getDesktop(). If the property is needed, i would suggest the changes provided in the patch. Additionaly the property m_outline could be set to final.
Comment 1 Stephan Leicht Vogt CLA 2011-11-15 03:48:38 EST
Thanks for the patch. I reviewed and applied it to trunk for Eclipse 3.8
Comment 2 Matthias Zimmermann CLA 2012-07-09 06:50:12 EDT
ticket closed.
deliverd as part of eclipse scout 3.8.0 (juno release train)