Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363695 - In context of EMFT Transaction have invalid cross reference resolution in option.
Summary: In context of EMFT Transaction have invalid cross reference resolution in opt...
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 08:34 EST by Esteban DUGUEPEROUX CLA
Modified: 2020-12-11 10:32 EST (History)
2 users (show)

See Also:

Attachments
A possible implementation (7.47 KB, patch)
2011-11-14 08:34 EST, Esteban DUGUEPEROUX CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Esteban DUGUEPEROUX CLA 2011-11-14 08:34:21 EST 
Build Identifier: CDO 4.0

In EMFT Transaction context, invalid cross references deletion should be done in EMF Command. In consequence we should have a notion of InvalidCrossReferenceResolver to be specified in CDOTransaction.Options. See attached patch for a possible impl.

Reproducible: Always
Comment 1 Esteban DUGUEPEROUX CLA 2011-11-14 08:34:58 EST 
Created attachment 206938 [details]
A possible implementation
Comment 2 Eike Stepper CLA 2011-11-15 02:01:39 EST 
Hi Esteban, I can not apply your patch because the paths in it all start with "a/plugins/...". I'm very sorry that our Git migration leaves us all with a situation that our former tools do not work anymore and we have to learn a lot of new things about best Git usage. I hope that Stefan, Martin and I can spend the coming weekend to define our new development and contribution process (incl wiki docs). I think a good process would be that contributors create a clone at GitHub, isolate their changes in a branch and add a comment to the bugzilla when I can start to fetch those changes for a review and possible commit to the central repo.

More important, I have the feeling that you created the patch against CDO 4.0 but there's no way we apply such (API breaking) enhancements in a maintenance stream.
Comment 3 Esteban DUGUEPEROUX CLA 2011-11-15 03:16:47 EST 
I understand that patch application can't be done on maintenance branch because of API break, can make sense for 4.1?
The patch has been created with EGit, you can apply it in removing 2 segment from the workspace to have a patch relative to the workspace root.
I can't find github cdo repo, can you tell me the url?

Thanks.
Comment 4 Eike Stepper CLA 2012-08-14 22:57:35 EDT 
Moving all open issues to 4.2. Open bugs can be ported to 4.1 maintenance after they've been fixed in master.
Comment 5 Eike Stepper CLA 2013-06-27 04:08:28 EDT 
Moving all outstanding enhancements to 4.3
Comment 6 Esteban DUGUEPEROUX CLA 2013-09-03 09:44:24 EDT 
The patch has been updated through a gerrit entry : https://git.eclipse.org/r/#/c/16035/
This feature request is especially usefull as in our use case we cannot remove stale references between locally detached object and remotely commited dirty objects because the remotely commited dirty objects can be locked by another client. With that feature request, we leave the API user manage itself these stale references on invalidation.
Comment 7 Eike Stepper CLA 2014-08-19 09:27:38 EDT 
Moving all open enhancement requests to 4.4
Comment 8 Eike Stepper CLA 2014-08-19 09:37:15 EDT 
Moving all open enhancement requests to 4.4
Comment 9 Eclipse Genie CLA 2015-05-14 06:11:49 EDT 
Gerrit change https://git.eclipse.org/r/16035 was merged to [master].
Commit: http://git.eclipse.org/c/cdo/cdo.git/commit/?id=fe0aaaf61faac3cab201cb5f3b16fec4f903c9b9
Comment 10 Esteban DUGUEPEROUX CLA 2015-05-20 07:33:50 EDT 
Fixed.
Comment 11 Eike Stepper CLA 2020-12-11 10:25:51 EST 
Closing.
Comment 12 Eike Stepper CLA 2020-12-11 10:32:14 EST 
Closing.