Community
Participate
Working Groups
Build Identifier: 20110916-0149 It is necessary for me to change the default key binding for the Commit in EGit as command+(shift+3) is the os shortcut for taking a screen shot. I picked command+k modeled after Pycharm. When I use the shortcut no dialog comes up as I would expect it to when right clicking Team->commit. There are no conflicts and command+k works in other applications (Iterm2 and Clearing the console) Here is a pretty screenshot of my key bindings: http://i.imgur.com/EzolB.png Reproducible: Always Steps to Reproduce: 1. push keyboard shortcut for Commit Nothing happens.
Jason, please put your comments and findings in bug 356647. *** This bug has been marked as a duplicate of bug 356647 ***
Not a dup. The problem here is that the Commit... shortcut is not handled unless the Git action set group is active in the current perspective. A workaround is to do "Window > Customize Perspective...", go to the "Command Groups Availability" tab, and make sure "Git" is checked in the left column. The "Customize Perspective" dialog is still very broken in 4.2 and 4.3 (bug 378849), so have to close the dialog and then reopen it if you want hide the "Git" toolbar again.
(In reply to comment #2) > Not a dup. > > The problem here is that the Commit... shortcut is not handled unless the > Git action set group is active in the current perspective. A workaround is > to do "Window > Customize Perspective...", go to the "Command Groups > Availability" tab, and make sure "Git" is checked in the left column. > > The "Customize Perspective" dialog is still very broken in 4.2 and 4.3 (bug > 378849), so have to close the dialog and then reopen it if you want hide the > "Git" toolbar again. so should this bug be moved to platform ?
I think the problem from comment 2 has been fixed in the meantime. But I found that the fix for bug 356647 was bad, since it missed to declare the platform in the deletion marker, so it effectively deletes the key binding on all platforms. Robin R did notice this, but unfortunately, I convinced him that the fix was OK. Sorry about that. Fix: https://git.eclipse.org/r/#/c/10586/ This is a regression compared to 2.2. It would be good to add this fix to 2.3.1.
merged as da62d62de46736242b4ef0411f3450514f9b40c8
Verified on Windows 7 with 2.4.0.201302242046 that it works. Someone on a Mac should also verify it.
I am using Eclipse Kepler sr1 with Egit 3.2.0-something on Linux and still have this problem. I confirm that adding git in "Customize perspective" > "Command groups availability" is a workaround, but it clutters GUI with lots of icons I will never touch. The default shortcut (ctrl+shift+3) works perfectly in e.g. Package Explorer or Git Repositories views, but not in Java editor. I checked preferences>keys but could not find anything conflicting. There is "Shift+Ctrl+3" shortcut for javascript debugging (i edit java, not javascript), but removing the shortcut does not help. Is it something broken in my eclipse config?
