Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363573 - [Xtend] Remove dependency on Google Guice
Summary: [Xtend] Remove dependency on Google Guice
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 364123
Blocks:
  Show dependency tree
 
Reported: 2011-11-11 06:32 EST by Peter Kriens CLA
Modified: 2017-09-19 17:57 EDT (History)
1 user (show)

See Also:
sven.efftinge: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kriens CLA 2011-11-11 06:32:16 EST 
When you run xtend you must have Google Inject on the class path. I guess I understand the (unfortunate) dependency on the xtend and xtext libraries but I fail to see why Google Guice should be mandatory?
Comment 1 Sven Efftinge CLA 2011-11-11 06:43:54 EST 
The dependency to google inject is optional and there to advocate the use of it. But you are right that there is no runtime or compile time dependency.

Does it cause you any trouble?
Comment 2 Peter Kriens CLA 2011-11-11 12:47:04 EST 
Yes, it does. I am not using xtend with PDE, I use bndtools. With bndtools we want to minimize dependencies as much as possible. However, I now get an error when I do not include Google Guice on the classpath.
Comment 3 Sven Efftinge CLA 2011-11-11 13:03:06 EST 
Ok, I think we should reconsider having it, but I wonder why bnd complains although it's marked optional. Is that an equinox-specific option?
Comment 4 Sven Efftinge CLA 2011-11-11 15:47:19 EST 
I realized that we actually have a compiler check which checks for google guice. We should get rid of the check and also should remove the dependency.
Comment 5 Sven Efftinge CLA 2011-11-11 16:17:02 EST 
I removed the compiler check.
Comment 6 Peter Kriens CLA 2011-11-14 09:53:03 EST 
Yup, that was the problem. Thanks! Looking forward to work more with xtend!
Comment 7 Sven Efftinge CLA 2011-11-21 05:33:12 EST 
There is a new library bundle (org.eclipse.xtend2.lib) which doesn't depend on com.google.inject.
Comment 8 Sven Efftinge CLA 2011-11-21 05:34:16 EST 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=364123
Comment 9 Karsten Thoms CLA 2017-09-19 17:46:32 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 10 Karsten Thoms CLA 2017-09-19 17:57:35 EDT 
Closing all bugs that were set to RESOLVED before Neon.0