Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363568 - Commit viewer should have a Compare Mode toggle button
Summary: Commit viewer should have a Compare Mode toggle button
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 06:11 EST by Markus Keller CLA
Modified: 2012-11-06 09:09 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-11-11 06:11:15 EST 
The commit viewer uses the Compare Mode setting from the history view, but it doesn't show the current mode nor does it allow to toggle the mode. This makes double-click and Enter in the Files section unpredictable.

Either add a Compare Mode toggle button to the commit viewer (preferred) or choose one default action.
Comment 1 Robin Stocker CLA 2012-11-05 17:30:22 EST 
(In reply to comment #0)
> Either add a Compare Mode toggle button to the commit viewer (preferred)

Would that be a separate setting or would that button also toggle the History view's compare mode? I think the former would be preferred, right?
Comment 2 Markus Keller CLA 2012-11-06 09:09:45 EST 
> Would that be a separate setting or would that button also toggle the
> History view's compare mode? I think the former would be preferred, right?

Yes, a separate setting would give maximum flexibility.