Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363566 - checkValueValid on DirectEditingFeatures not called when set
Summary: checkValueValid on DirectEditingFeatures not called when set
Status: CLOSED WORKSFORME
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 05:51 EST by Adrian Mouat CLA
Modified: 2011-11-11 09:48 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Mouat CLA 2011-11-11 05:51:12 EST 
I implemented the checkValueValid method for my direct editing feature. This method gets called when I start to edit, but not when I've made my changes. 

Therefore, I can make an invalid change and save it. If I try to do direct edit again, the error message appears immediately.
Comment 1 Michael Wenz CLA 2011-11-11 08:21:15 EST 
The tutorial is the example that shows the method is called also while editing. Maybe you have a special situation:
- What kind of direct editing type do you use? 
- What type has the attribute edited in the field?
- Could you provide a small sample to reproduce?
Comment 2 Adrian Mouat CLA 2011-11-11 09:04:02 EST 
(In reply to comment #1)
> The tutorial is the example that shows the method is called also while editing.
> Maybe you have a special situation:
> - What kind of direct editing type do you use? 
> - What type has the attribute edited in the field?
> - Could you provide a small sample to reproduce?

Apologies, I was just being stupid.

I had to do a test on the linked model object, so I took the value from there rather than the passed in value...

Sorry for wasting your time.