Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363535 - DBWSBuilder should set javaClassName for Object/Varray/ObjectTable types to NOT be in Java's default package
Summary: DBWSBuilder should set javaClassName for Object/Varray/ObjectTable types to N...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 15:39 EST by Mike Norman CLA
Modified: 2022-06-09 10:29 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix. (20.86 KB, patch)
2012-01-11 13:12 EST, David McCann CLA 		no flags Details | Diff
Supporting test cases. (9.24 KB, patch)
2012-01-11 13:14 EST, David McCann CLA 		no flags Details | Diff
Proposed fix v2. (23.36 KB, patch)
2012-01-12 13:15 EST, David McCann CLA 		no flags Details | Diff
Supporting test cases. (9.24 KB, patch)
2012-01-12 13:15 EST, David McCann CLA 		no flags Details | Diff
Proposed fix v3. (24.76 KB, patch)
2012-01-12 14:27 EST, David McCann CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Norman CLA 2011-11-10 15:39:58 EST 

    


    


      



        
          Comment 1
        

        
          David McCann CLA

        

        
        

        
          2012-01-11 13:12:45 EST
        

      






Created attachment 209334 [details]
Proposed fix.

We now prepend the package (project name + '.') to the Java class name for Object, ObjectTable and VArray types.

    


    


      



        
          Comment 2
        

        
          David McCann CLA

        

        
        

        
          2012-01-11 13:14:26 EST
        

      






Created attachment 209335 [details]
Supporting test cases.

The existing Object, ObjectTable and VArray test suites were modified to also check the Java class names of the processed types to verify that the package was prepended properly.

    


    


      



        
          Comment 3
        

        
          David McCann CLA

        

        
        

        
          2012-01-12 13:15:02 EST
        

      






Created attachment 209397 [details]
Proposed fix v2.

Now uses an existing method on Util class that returns the correct java class name.

    


    


      



        
          Comment 4
        

        
          David McCann CLA

        

        
        

        
          2012-01-12 13:15:20 EST
        

      






Created attachment 209398 [details]
Supporting test cases.

    


    


      



        
          Comment 5
        

        
          David McCann CLA

        

        
        

        
          2012-01-12 14:27:35 EST
        

      






Created attachment 209402 [details]
Proposed fix v3.

Added default project name (myProject) to handle null/empty string project names.

    


    


      



        
          Comment 6
        

        
          David McCann CLA

        

        
        

        
          2012-01-12 15:50:50 EST
        

      






Reviewed by:  michael.norman@oracle.com
Tests:  All unit tests pass as expected; ObjectTypeTestSuite, ObjectTableTypeTestSuite and VArrayTestSuite modded

Revision: 10679

    


    


      



        
          Comment 7
        

        
          Eclipse Webmaster CLA

        

        
        

        
          2022-06-09 10:29:34 EDT
        

      






The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink