Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363473 - Confirm support for expression language in jsp
Summary: Confirm support for expression language in jsp
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Server-Side (show other bugs)
Version: 3.8.0 Juno   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: equinox.server-side-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 09:25 EST by Thomas Watson CLA
Modified: 2019-11-03 00:42 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2011-11-10 09:25:50 EST
In bug 362724 there is mention of the help feature requiring an implementation of el (expression language).  I am not familiar with all that is required to support el in our jsp support, but I am not convinced our jetty 8 based HttpService supports this.  Simon A., please investigate and provide a testcase.
Comment 1 Thomas Watson CLA 2011-11-10 09:36:46 EST
Also see bug 309529 comment 36.
Comment 2 Thomas Watson CLA 2011-11-10 09:51:28 EST
Also see bug 309529 comment 40.
Comment 3 Thomas Watson CLA 2011-11-10 10:48:58 EST
FYI, in my investigations I had to add an import for com.sum.el from the bundle declaring the jsp in order for jsps with el syntax to work.  This seems less that optimal.

Not sure if or how this worked in our current jetty 6 and servlet 2.x support.
Comment 4 Hugues Malphettes CLA 2011-11-10 12:30:15 EST
(In reply to comment #3)
> FYI, in my investigations I had to add an import for com.sum.el from the bundle
> declaring the jsp in order for jsps with el syntax to work.  This seems less
> that optimal.
> 
> Not sure if or how this worked in our current jetty 6 and servlet 2.x support.

In jetty-osgi bundles we wire the bundles and make the resulting classloader available to the web-bundles. We did do a similar import [1]. Things are a lot more explicit in OSGi than in J2EE's flat class-loaders and our primary goal at the time was to avoid touching existing code and library at the cost of complexity in our own code.

In Apache-land I have seen geronimo and service-mix introducing OSGi services directly inside the libraries to handle this type of thing better. They chose to add some OSGi specific code to the libraries though [2]

[1] http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-osgi/jetty-osgi-boot-jsp/META-INF/MANIFEST.MF
[2] http://svn.apache.org/repos/asf/geronimo/specs/tags/geronimo-osgi-support-1.1/geronimo-osgi-registry/pom.xml
Comment 5 Thomas Watson CLA 2011-11-10 13:20:28 EST
(In reply to comment #4)
Thanks Hugues, we setup a JSPClassLoader also that uses the bundle's classloader declaring the jsp and has a parent class loader which is the bundle class loader of the jasper implementation (org.apache.jasper.glassfish).  Perhaps we need to somehow grant this class loader access to the el implementation package.
Comment 6 Eclipse Genie CLA 2019-11-03 00:42:50 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.