Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363468 - Configure... on Push and Push to Upstream should match the current spec
Summary: Configure... on Push and Push to Upstream should match the current spec
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Stefan Lay CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 09:10 EST by Dani Megert CLA
Modified: 2011-11-21 06:16 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-11-10 09:10:35 EST 
1.2.

'Push' and 'Push to Upstream' only push the checked out branch - which is good. But, when one chooses 'Configure...' in the 'Push Results' dialog, it starts with a push spec that pushes all branches. This is quite misleading and can result in all local branches being pushed.
Comment 1 Stefan Lay CLA 2011-11-16 02:29:33 EST 
That's true.

The description in the dialog and the behavior of the dry-run are wrong and do not match the default behavior of 'Push' and 'Push to Upstream'.

I still don't see why it can result in all local branches being pushed. When you leave the Refspec field as it is 'Push' and 'Push to Upstream' will only push the checked out branch.
Comment 2 Dani Megert CLA 2011-11-16 03:01:11 EST 
> I still don't see why it can result in all local branches being pushed. When
> you leave the Refspec field as it is 'Push' and 'Push to Upstream' will only
> push the checked out branch.
Right, but if after the "normal" push in the result dialog you do

1. click 'Configure...'
2. click 'Dry-Run'
==> it says that all local branches will be pushed!

But guess what? I now tried
3. click 'Save and Push'
and this indeed did not push the branches unlike indicated by the dry-run.
Comment 3 Stefan Lay CLA 2011-11-16 03:13:42 EST 
Fix proposed:  http://egit.eclipse.org/r/4625
Comment 4 Dariusz Luksza CLA 2011-11-18 17:00:56 EST 
Merged as commit a8558f4ec0b2c578b7bc0f514d9e0f8b3035724d
Comment 5 Dani Megert CLA 2011-11-21 06:16:45 EST 
Verified in 1.2.0.201111201913.