Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363464 - AbstractFeature.layoutPictogramElement() should return IReason
Summary: AbstractFeature.layoutPictogramElement() should return IReason
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Juno M4 Theme_round_offs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 08:56 EST by Hernan Gonzalez CLA
Modified: 2012-06-29 04:13 EDT (History)
2 users (show)

See Also:
michael.wenz: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hernan Gonzalez CLA 2011-11-10 08:56:32 EST 
Build Identifier: 

Currently (0.9.0) AbstractFeature.layoutPictogramElement()  returns void, swallowing the getFeatureProvider().layoutIfPossible(context) returned IReason.
Not a big deal, because the method is protected (rather an utility method), but nevertheless to change the signature to return IReason seems the logical thing, it could be useful and does not break anything.

Reproducible: Always
Comment 1 Michael Wenz CLA 2011-11-11 03:57:08 EST 
The method returns now the IReason object to pass on this information. The change will affect all users (subclasses) of AbstractFeature that have overridden layoutPictogramElement; this should not be many - hopefully none - since I see no real reason why one should do that.
Checked in and pushed to Eclipse:
commit d0ad1625ec8fef4e1b386d3fba37c198970a9d52
Author: mwenz <michael.wenz@sap.com> 2011-11-11 09:53:23
Committer: mwenz <michael.wenz@sap.com> 2011-11-11 09:53:23
Parent: 857c60509a4d519bdd715022e39f0bdea3aa0de6 (Hide some irrelevant html and xml warnings)
Branches: origin/master, master
Comment 2 Michael Wenz CLA 2011-11-11 03:57:31 EST 
Of course M4 not M3
Comment 3 Michael Wenz CLA 2012-04-11 10:44:54 EDT 
Bookkeeping: Set target release
Comment 4 Michael Wenz CLA 2012-06-29 04:13:38 EDT 
Part of Graphiti 0.9.0 (Eclipse Juno)