Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363436 - Debug buttons should not be enabled
Summary: Debug buttons should not be enabled
Status: RESOLVED DUPLICATE of bug 552350
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 380231 404759 406869 410903 442958 487789 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-10 04:21 EST by Ayushman Jain CLA
Modified: 2020-04-28 04:46 EDT (History)
17 users (show)

See Also:


Attachments
snapshot of "Customize perspective.." dialog (17.97 KB, image/jpeg)
2011-11-10 04:22 EST, Ayushman Jain CLA
no flags Details
snapshot showing active debug actions (10.98 KB, image/jpeg)
2011-11-10 10:35 EST, Ayushman Jain CLA
no flags Details
empty space in the coolbar (5.87 KB, image/jpeg)
2011-11-10 10:40 EST, Ayushman Jain CLA
no flags Details
Debug menu items in 3.7 (14.72 KB, image/png)
2013-05-02 04:46 EDT, Dani Megert CLA
no flags Details
Global Debug Toolbar in 4.4 M7 (1.20 MB, image/png)
2014-04-24 05:48 EDT, Sarika Sinha CLA
no flags Details
Global Debug Toolbar in 4.4 M7 (13.12 KB, image/png)
2014-04-24 09:45 EDT, Sarika Sinha CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ayushman Jain CLA 2011-11-10 04:21:12 EST
Builld id: M3

1)The global debug toolbar is always "active" when I launch my Eclipse workbench 
for the first time, even though no debug session is in progress.

2) The "tool bar visibility" settings do not respect the "command group visibility" settings in the "Customize persepctive.." dialog ONLY in java perspective. When I uncheck the "Debug" command group in the command groups visibility tab, and go back to "tool bar visibility", I'm allowed to select the debug option, and even expand it and select the "skip all breakpoints" option. All the other sub-options are greyed out though.
Comment 1 Ayushman Jain CLA 2011-11-10 04:22:01 EST
Created attachment 206764 [details]
snapshot of "Customize perspective.." dialog
Comment 2 Dani Megert CLA 2011-11-10 09:15:18 EST
> 1)The global debug toolbar is always "active" when I launch my Eclipse
> workbench 
You mean you see all action, not just the 'Skip all breakpoints' action? When I try it, I only see that one and this is as designed.
Comment 3 Ayushman Jain CLA 2011-11-10 10:35:14 EST
Created attachment 206788 [details]
snapshot showing active debug actions

(In reply to comment #2)
> > 1)The global debug toolbar is always "active" when I launch my Eclipse
> > workbench 
> You mean you see all action, not just the 'Skip all breakpoints' action? When > I try it, I only see that one and this is as designed.

Basically 1) and 2) are unrelated cases here. To reproduce 1) do this:
- Enable debug command group in "Customize perspective.."'s command groups availability, and then enable all debug actions under the tool bar visibility tab.
- Make sure all actions appear on the coolbar and restart the workbench.
- On restart, you will find that all debug actions are in a coloured active state. Expected: They should be greyed out since no debug session is in progress.
(This is a very minor problem though, since when I click on any debug action, I get a dialog that this is not available and all of them grey out immediately.)
Comment 4 Ayushman Jain CLA 2011-11-10 10:40:27 EST
Created attachment 206789 [details]
empty space in the coolbar

This snapshot shows what happens in the case 2) in comment 0 i.e. when I select only the breakpoints action and disable the debug command group availability, I get an empty space in the coolbar.
Comment 5 Remy Suen CLA 2011-11-18 11:30:34 EST
Given your screenshots and the version field, I'm assuming you're using 3.8. Could you confirm this, Ayushman? Thanks.
Comment 6 Ayushman Jain CLA 2011-11-18 11:41:12 EST
(In reply to comment #5)
> Given your screenshots and the version field, I'm assuming you're using 3.8.
> Could you confirm this, Ayushman? Thanks.

Yup. 3.8 indeed, though I expect these to be the same on 4.2 as well.
Comment 7 Remy Suen CLA 2011-11-21 10:09:00 EST
(In reply to comment #6)
> (In reply to comment #5)
> > Given your screenshots and the version field, I'm assuming you're using 3.8.
> > Could you confirm this, Ayushman? Thanks.
> 
> Yup. 3.8 indeed, though I expect these to be the same on 4.2 as well.

Well, the empty space problem shouldn't happen in 4.x. I think that's a long standing bug with 3.x.
Comment 8 Michael Rennie CLA 2012-05-24 12:50:17 EDT
*** Bug 380231 has been marked as a duplicate of this bug. ***
Comment 9 Jimmy Krag CLA 2013-03-26 06:43:15 EDT
Could you please have a look at bug #404348 and tell me if this is related?
Comment 10 Fredrik Attebrant CLA 2013-04-12 08:46:26 EDT
Ran into problem #1 with Eclipse 3.8.
Went on to try reproducing it with 4.2 and 4.3M6.

Did this on Linux and Mac and noted the following (applies to 3.8, 4.2 and 4.3M6):

If the Debug view is NOT shown and the Debug commands group is visible in the toolbar of the current perspective, then the Debug actions are enabled when Eclipse is launched.

As soon as I open the Debug view, the actions gets disabled (as they should be).
Comment 11 Michael Rennie CLA 2013-04-12 10:51:11 EDT
*** Bug 404759 has been marked as a duplicate of this bug. ***
Comment 12 Dani Megert CLA 2013-04-15 08:03:08 EDT
This works as designed. We explicitly do not want to load a bundle just to detect the correct enabling of its actions. The state is updated as soon as the bundle is loaded or the action executed.
Comment 13 Dani Megert CLA 2013-04-30 04:54:55 EDT
*** Bug 406869 has been marked as a duplicate of this bug. ***
Comment 14 Fredrik Attebrant CLA 2013-05-02 04:29:54 EDT
Why not have them disabled until the bundle is loaded and can enable them explicitly?
Comment 15 Dani Megert CLA 2013-05-02 04:44:50 EDT
(In reply to comment #14)
> Why not have them disabled until the bundle is loaded and can enable them
> explicitly?

You're right. Only the buttons that can trigger the loading, like e.g. launch something or toggle a breakpoint should be enabled. From the Debug command group only "Use Step Filters" needs to be enabled.

This worked fine for the menus in 3.7, but got broken with the introduction of the global Debug toolbar.
Comment 16 Dani Megert CLA 2013-05-02 04:46:26 EDT
Created attachment 230389 [details]
Debug menu items in 3.7
Comment 17 Paul Webster CLA 2013-05-02 07:48:55 EDT
(In reply to comment #14)
> Why not have them disabled until the bundle is loaded and can enable them
> explicitly?

Tool and Menu items are enabled until the plugin is activated so that selecting them can be used to trigger the plugin activation.

The framework can't tell which ones make sense to disable by default currently.  it would have to be an opt-in enhancement added to the appropriate extension point (default enablement if the contributing plugin is not active).

PW
Comment 18 Dani Megert CLA 2013-05-02 07:58:55 EDT
(In reply to comment #17)
> (In reply to comment #14)
> > Why not have them disabled until the bundle is loaded and can enable them
> > explicitly?
> 
> Tool and Menu items are enabled until the plugin is activated so that
> selecting them can be used to trigger the plugin activation.
> 
> The framework can't tell which ones make sense to disable by default
> currently.  it would have to be an opt-in enhancement added to the
> appropriate extension point (default enablement if the contributing plugin
> is not active).

In 3.7 the debug actions appeared disabled in the menu, so there must be a way to do this ;-). Only in 3.8 this got changed by the new Debug global toolbar.
Comment 19 Jan Koehnlein CLA 2013-06-01 05:04:01 EDT
Still an issue with Kepler RC2. Is there chance to get this fixed for Kepler?
Comment 20 Dani Megert CLA 2013-06-03 04:47:10 EDT
It's too late for 4.3.
Comment 21 Dani Megert CLA 2013-06-17 06:14:51 EDT
*** Bug 410903 has been marked as a duplicate of this bug. ***
Comment 22 Sarika Sinha CLA 2014-04-24 05:45:55 EDT
Version: Luna (4.4)
Build id: I20140422-0800

Attaching the screen shot of Toolbar. Works as expected.

For point 2 of Problem Description, Dani has already provided the reason.
Comment 23 Sarika Sinha CLA 2014-04-24 05:48:42 EDT
Created attachment 242274 [details]
Global Debug Toolbar in 4.4 M7
Comment 24 Markus Keller CLA 2014-04-24 09:33:11 EDT
(In reply to Sarika Sinha from comment #23)
> Created attachment 242274 [details]
> Global Debug Toolbar in 4.4 M7

This is a menu, not a toolbar. Attachment 206788 [details] from comment 3 shows the global toolbar.
Comment 25 Sarika Sinha CLA 2014-04-24 09:45:27 EDT
Created attachment 242286 [details]
Global Debug Toolbar in 4.4 M7

Thanks Markus.
Here goes the toolbar snapshot from latest build.
Comment 26 Markus Keller CLA 2014-04-24 10:32:31 EDT
N20140423-2200: new workspace, close Welcome, Window > Customize Perspective... > Command Groups Availability > check "Debug" > OK

=> Actions like Step Into are enabled in global toolbar and in Run menu. In 3.8.2, they were disabled and only Debug, Run, and Skip All Breakpoints were enabled in the toolbar.

The enablement gets fixed once the debug plug-in is loaded (e.g. the Debug view or perspective is opened).
Comment 27 Noopur Gupta CLA 2014-09-01 02:32:02 EDT
*** Bug 442958 has been marked as a duplicate of this bug. ***
Comment 28 Simon Morgan CLA 2015-02-20 09:15:47 EST
Bug is still present in 4.4.1.
Comment 29 Tobias Gierke CLA 2015-08-26 03:28:56 EDT
Bug is still present in 4.5.0
Comment 30 Sarika Sinha CLA 2016-02-15 01:36:18 EST
*** Bug 487789 has been marked as a duplicate of this bug. ***
Comment 31 Robert Pofuk CLA 2016-05-17 08:25:32 EDT
4.6M7 has same problem as well. On linux is even worse since you can't click Terminate to make them disables.
Comment 32 Danilo Cominotti Marques CLA 2016-12-23 11:27:42 EST
Any updates on this? We are already in Neon.2 and the bug is still present.
Comment 33 Sarika Sinha CLA 2017-01-02 04:14:09 EST
(In reply to Danilo Cominotti Marques from comment #32)
> Any updates on this? We are already in Neon.2 and the bug is still present.

Unfortunately, no one is working on it right now. 
We welcome good quality patches.
Comment 34 Paul Pazderski CLA 2020-04-28 04:46:33 EDT
Fixed since 2019-12 with bug 552350.

*** This bug has been marked as a duplicate of bug 552350 ***