Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363385 - Performance Improvement - NamespaceResolver reduce unnecessary instances of Map
Summary: Performance Improvement - NamespaceResolver reduce unnecessary instances of Map
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 16:11 EST by Blaise Doughan CLA
Modified: 2022-06-09 10:27 EDT (History)
1 user (show)

See Also:

Attachments
Core - Fix (5.61 KB, patch)
2011-11-09 16:23 EST, Blaise Doughan CLA 		no flags Details | Diff
Core - Fix (3.63 KB, patch)
2011-11-11 13:57 EST, Blaise Doughan CLA 		no flags Details | Diff
Core - Fix (14.50 KB, patch)
2011-11-11 16:07 EST, Blaise Doughan CLA 		no flags Details | Diff
MOXy - Fix (1.10 KB, patch)
2011-11-11 16:08 EST, Blaise Doughan CLA 		no flags Details | Diff
Core - Fix (2.3.2) (14.50 KB, patch)
2011-11-14 09:59 EST, Blaise Doughan CLA 		no flags Details | Diff
Core - Fix (Trunk) (14.23 KB, patch)
2011-11-14 11:31 EST, Blaise Doughan CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Blaise Doughan CLA 2011-11-09 16:11:08 EST 
Currently NamespaceResolver holds an instance of Map to maintain key/uri pairs even when it doesn't need one.
Comment 1 Blaise Doughan CLA 2011-11-09 16:23:31 EST 
Created attachment 206739 [details]
Core - Fix
Comment 2 Blaise Doughan CLA 2011-11-11 13:57:10 EST 
Created attachment 206866 [details]
Core - Fix
Comment 3 Blaise Doughan CLA 2011-11-11 16:07:57 EST 
Created attachment 206874 [details]
Core - Fix
Comment 4 Blaise Doughan CLA 2011-11-11 16:08:38 EST 
Created attachment 206875 [details]
MOXy - Fix
Comment 5 Blaise Doughan CLA 2011-11-14 09:59:16 EST 
Created attachment 206950 [details]
Core - Fix (2.3.2)
Comment 6 Blaise Doughan CLA 2011-11-14 11:31:09 EST 
Created attachment 206960 [details]
Core - Fix (Trunk)
Comment 7 Blaise Doughan CLA 2011-11-14 13:29:14 EST 
Fix checked into 2.3.2 at rev:  10383
Fix checked into trunk at rev:  10384

Code reviewed by:  Matt MacIvor

Fix Details:
Lazy initialize the prefixesToNamespaces map, and added a hasPrefixesToNamespaces check to avoid the lazy initialization when it is not required.
Comment 8 Eclipse Webmaster CLA 2022-06-09 10:27:31 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink