Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363357 - Resource names in text should be in single quotes not double quotes
Summary: Resource names in text should be in single quotes not double quotes
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 12:06 EST by Dani Megert CLA
Modified: 2011-11-17 05:33 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-11-09 12:06:35 EST 
1.2.

Resource names in text should be in single quotes not double quotes.
Comment 1 Kevin Sawicki CLA 2011-11-09 12:10:17 EST 
Where are you seeing this?
Comment 2 Dani Megert CLA 2011-11-09 12:14:08 EST 
(In reply to comment #1)
> Where are you seeing this?

E.g. in the Compare With > Branch, Tag or Reference... dialog. I think I found around 30 reference when searching for:
"{?}"
Comment 3 Kevin Sawicki CLA 2011-11-14 13:12:19 EST 
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4614

Found 21 strings, some with multiple occurrences
Comment 4 Dani Megert CLA 2011-11-15 07:04:41 EST 
(In reply to comment #3)
> Proposed fix pushed to: http://egit.eclipse.org/r/#change,4614
> 
> Found 21 strings, some with multiple occurrences

I found more because I also searched JGit. Filed bug 363804 for that.

I also filed FUP bug bug 363805.
Comment 5 Matthias Sohn CLA 2011-11-15 14:18:40 EST 
merged as cf6697f255e38f7138e192d2d40a2578238d2b72
Comment 6 Dani Megert CLA 2011-11-17 05:33:25 EST 
Verified in 1.2.0.201111161624.