Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363230 - Mangling of source jars retrieved from maven fails on Windows
Summary: Mangling of source jars retrieved from maven fails on Windows
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 16:53 EST by Michal Ruzicka CLA
Modified: 2019-02-25 14:40 EST (History)
1 user (show)

See Also:

Attachments
org.eclipse.buckminster.core-maven_source_jar.patch (634 bytes, patch)
2011-11-08 16:53 EST, Michal Ruzicka CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Ruzicka CLA 2011-11-08 16:53:45 EST 
Created attachment 206630 [details]
org.eclipse.buckminster.core-maven_source_jar.patch

Mangling of source bundle jars retrieved from maven - governed by the "buckminster.convert.source" property - fails on Windows. A warning similar to the following one is displayed in the Buckminster console:

Unable to rename C:\Install\Eclipse\Platform\plugins\hazelcast.source_1.9.4.jar to C:\Install\Eclipse\Platform\plugins\oldbundle-1717893016361118425.jar

The problem is that Windows refuse to overwrite an existing file when performing 
File.renameTo(File). The attached trivial patch fixes the issue.
Comment 1 Thomas Hallgren CLA 2011-11-12 09:15:24 EST 
Looks good to me. I suggest you commit this.