Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363212 - Plugins that are used only by Gprof and Gcov were added as a dependency for oprofile and valgrind
Summary: Plugins that are used only by Gprof and Gcov were added as a dependency for o...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Xavier Raynaud CLA
QA Contact: Xavier Raynaud CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 12:53 EST by Otavio Pontes CLA
Modified: 2022-01-13 14:51 EST (History)
2 users (show)

See Also:

Attachments
Remove the dependency from profiling feature (2.33 KB, patch)
2011-11-09 06:54 EST, Otavio Pontes CLA 		no flags Details | Diff
Adding the removed dependencies back to gprof and gcov (2.65 KB, patch)
2011-11-09 06:55 EST, Otavio Pontes CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Otavio Pontes CLA 2011-11-08 12:53:51 EST 
Build Identifier: I20110613-1736

The plugins org.eclipse.linuxtools.binutils, org.eclipse.linuxtools.dataviewers, 
org.eclipse.linuxtools.dataviewers.charts, org.eclipse.linuxtools.dataviewers.annotatedsourceeditor that are only used by gprof and gcov were added as a dependency for org.eclipse.linuxtools.profiling-feature.
The problem is that oprofile and valgrind depends on org.eclipse.linuxtools.profiling feature, so they will require the installation of these unnecessary plugins. The greater problem for me is that this also adds indirectly the dependency for BIRT, DTP and EMF, that are large packages.
Since these packages are only used by gprof and gcov I suggest to remove them from org.eclipse.linuxtools.profiling-feature/feature.xml and add them to org.eclipse.linuxtools.gprof-feature/feature.xml and org.eclipse.linuxtools.gcov-feature/feature.xml.

Reproducible: Always

Steps to Reproduce:
1. Install only oprofile plugin in an eclipse installation
2. Note that some useless plugins were installed, like BIRT and org.eclipse.linuxtools.dataviewers.charts
Comment 1 Otavio Pontes CLA 2011-11-09 06:54:12 EST 
Created attachment 206676 [details]
Remove the dependency from profiling feature

This revert the commit that adds unnecessary dependencies into profiling.
Comment 2 Otavio Pontes CLA 2011-11-09 06:55:02 EST 
Created attachment 206677 [details]
Adding the removed dependencies back to gprof and gcov

This patch adds the dependencies back to gprof and gcov
Comment 3 Otavio Pontes CLA 2011-11-10 09:54:10 EST 
Jeff Johnston created a new feature for dataviewers and binutils. 
This bug was fixed by commits 50937355abf3d5d6e75206865d8a409a8d4615a0 and 9745c96f06cdae797a0fd2baca5ef893207adff3