Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363084 - [Browser] NPE can occur when closing Browser in detached view
Summary: [Browser] NPE can occur when closing Browser in detached view
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.7.2   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-07 14:21 EST by Grant Gayed CLA
Modified: 2011-11-24 13:54 EST (History)
1 user (show)

See Also:
Silenio_Quarti: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2011-11-07 14:21:43 EST 
- open an Internal Web Browser view
- detach the view
- navigate the browser to eclipse.org
- give focus to the eclipse.org page's search text field, type a few characters
- close the view and the following exception occurs:

java.lang.NullPointerException
	at org.eclipse.swt.browser.MozillaDelegate$1.handleEvent(MozillaDelegate.java:141)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1282)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1263)
	at org.eclipse.swt.widgets.Shell.filterProc(Shell.java:748)
	at org.eclipse.swt.widgets.Display.filterProc(Display.java:1543)
	at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
	at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2287)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3207)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1431)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1407)
Comment 1 Grant Gayed CLA 2011-11-08 10:06:03 EST 
Fixed in the 3.8 stream > 20111108.  Planning to add this fix to the 3.7.2 stream soon, once it has had further opportunity to be tested in the 3.8 stream, so setting target milestone accordingly and leaving report open for now.  The changes are:

gtk: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=18076bd75b351c7ad4e30e5b488ce8c903e3ce53
cocoa: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=81705e679e0cec56416b7c6a3f33afab63230df0
Comment 2 Grant Gayed CLA 2011-11-24 11:09:08 EST 
Changes cherry-picked to the 3.7.2 stream > 20111124, marking as FIXED.