Community
Participate
Working Groups
More and more plugins are starting to use shared license feature.In order to not have to patch plugins o.e.license-feature should be made part of eclipse-build. 1. Modify buildSDKSource.sh to fetch the feature and whatever else is needed and put it in the tarball. 2. Build the feature as part of eclipse-build and install/provision it in the pde/sdk dropins folder.
Andrew, Because you have done something similar in the eclipse-wtp-commons.spec please take a look at it.
Created attachment 207177 [details] Patch to include the org.eclipse.license feature Patch to include the org.eclipse.license feature. Not entirely familiar with what is required for the build, so I would appreciate a review.
There are a few places in the eclipse-build build.xml where we install IUs. I think the default (or at least the one used in Fedora) is to install the platform IU and then put other stuff from the SDK in dropins. I think we probably want this license feature in the distros' platform packages so let's ensure we install it when installing that IU and not just when installing the SDK IU. My knowledge of what should go into sdk.product and what should go into other feature.xml files is weak so I guess sdk.product is fine but I'd appreciate Alex's comment on that. Thanks for the patch!
Without pretendging to have a deeper knowledge on the subject my understanding is that license feature is somekind of resource feature for PDE, i.e. nothing else but PDE can make use of it. From what I've seen in eclipse-wtp-commons by just having the feature in dropins everything should be fine so the current approach to install it with sdk seems fine to me. Andrew (Robinson), have you tried to build eclipse-wtp-commons with an SDK build having this feature installed by eclipse-build and the license feature removed from the eclipse-wtp-common sources?
I forgot to mention that in the case when pde/jdt are provisioned in dropins, license feature should be provisioned together with pde in dropins.
Pdebuild doesn't currently work correctly for plugins and features in the jdt/sdk dropins folder for reasons related to not following symlinks correctly. As is pdebuild resolves the feature but does not access its files. In Fedora downstream we do manual symlinks for all jdt/sdk plugins, but this feature doesn't have an associated plugin. If the feature is similarly manually symlinked eclipse-wtp-common builds correctly. I'm not sure what case you're referring to with pde/jdt provisioned in dropins. The only target I saw for provision*indropins was SDK, which provisions both SDK and JDT. Do you mean you always want it in JDT/PDE? Or is there some build case I'm missing.
Created attachment 208201 [details] License feature patch. This patch allows plugins to be built with PDE build using the license feature included in the main SDK. The major changes: The license feature is built/provisioned/installed. Copy-platform symlinks eclipse/plugins, eclipse/dropins/*/plugins, eclipse/feature, eclipse/dropins/*/features in that order. Patch added that changes build location relative generated license feature locations to absolute path to fix symlinking issue.
(In reply to comment #7) > Created attachment 208201 [details] > License feature patch. > > This patch allows plugins to be built with PDE build using the license feature > included in the main SDK. > > The major changes: > The license feature is built/provisioned/installed. > Copy-platform symlinks eclipse/plugins, eclipse/dropins/*/plugins, > eclipse/feature, eclipse/dropins/*/features in that order. > Patch added that changes build location relative generated license feature > locations to absolute path to fix symlinking issue. Andrew, with this patch applied can we skip the generated part from copy-platform.sh ?
Yes, one should be able to skip the generated portion, unless there is some plugin the builds on top of some eclipse platform non-feature/plugin files.
(In reply to comment #7) > Created attachment 208201 [details] > The license feature is built/provisioned/installed. This looks great, Andrew. I'll let Alex comment but without trying it myself it appears to do exactly what is needed. Thanks!
Comment on attachment 208201 [details] License feature patch. Patch applied in cca40be0bc4c0d1669adb4c99869d9370ebe36b2. Thanks!
Resolving.
