Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 363025 - Support Eclipse installations in target files (location type="Profile")
Summary: Support Eclipse installations in target files (location type="Profile")
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Christoph Laeubrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 550601
Blocks:
  Show dependency tree
 
Reported: 2011-11-07 03:43 EST by Meng Xin Zhu CLA
Modified: 2021-04-28 16:54 EDT (History)
6 users (show)

See Also:

Attachments
patch (33.20 KB, patch)
2011-11-07 03:47 EST, Meng Xin Zhu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Meng Xin Zhu CLA 2011-11-07 03:43:04 EST 
.target definition allows using existing installation that could speed up downloading artifacts from local environment, such as development.
Comment 1 Meng Xin Zhu CLA 2011-11-07 03:47:19 EST 
Created attachment 206508 [details]
patch

There is some limitations of eclipse installation as target platform, it's out of scope of this patch.

1. The installation does not have binary root IUs by default. So it's no way to build application or product that need launcher binary IUs.
2. The dir bundles can't be downloaded due to the default rule of artifacts.xml is mapping to jar file.
Comment 2 Tobias Oberlies CLA 2011-11-28 09:34:42 EST 
Meng, I am impressed about the scope of the change that your patch addresses. Unfortunately, I don't think that the solution is done in the right way: From what I understand, the locations of type "Profile" are fundamentally different from locations of type "InstallableUnit". Forcing TargetDefinitionFile.InstallationLocation under the TargetDefinition.InstallableUnitLocation interface requires a couple of hacks because the concepts just don't match. Also I have my doubts that it works correctly - did you ever try to mix "Profile" and "InstallableUnit" location types?

Another possible functional issue seems to be the handling of the <includeBundles> attribute. I thought that that attribute is supposed to work with any location type. In your patch, it only seems to work with location type "Profile". In any case, if you want to provide support for the <includeBundles> attribute, please do this in a separate patch.
Comment 3 Christoph Laeubrich CLA 2020-06-18 07:23:12 EDT 
@Meng Xin Zhu

Are you still interested in this feature? I'm currently adding support for this via Bug 538144 but I'm still a little bit uncertain what a "Eclipse Installation" should supply, you are talking about binaries and UIs but when I add such an installation to my target it only explains itself as:

> An installation (such as an Eclipse SDK) in the local file system.
> The installed plug-ins will be added to the target definition.

So it seems we should scan the bundles only (not features nor units or alike)?
Comment 4 Christoph Laeubrich CLA 2020-09-18 03:20:48 EDT 
This is available in Tycho 2.0 now, please open a new bug if something is missing for you in the current implementation.