Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362921 - RWT reports incorrect content-type for images
Summary: RWT reports incorrect content-type for images
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 2.0 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 12:20 EDT by Cole Markham CLA
Modified: 2013-03-01 09:30 EST (History)
3 users (show)

See Also:

Attachments
Patch to add file extensions to theme images and generated images in RWT (3.58 KB, patch)
2011-11-04 12:20 EDT, Cole Markham CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cole Markham CLA 2011-11-04 12:20:20 EDT 
Created attachment 206473 [details]
Patch to add file extensions to theme images and generated images in RWT

We ran into a problem on some client systems running IE8 where images coming from RAP were not being displayed. I tracked it down to an incorrect content-type being sent by the server since the filenames generated by RWT do not have extensions. I cannot figure out the IE setting to reproduce the error locally, but the attached patch fixes the problem on the client machines. Both theme images and generated images needed to be changed.
Comment 1 Ralf Sternberg CLA 2011-11-09 07:45:51 EST 
Hi Cole, thanks for the patch, it looks good to me at first sight. But without unit tests, how can we know that you did not oversee some corner cases, e.g. when dealing with indexOf() etc.? Sorry for nagging, but we really need tests ;-) Could you include them in the patch?
Comment 2 Ingo Meyer CLA 2012-10-05 02:56:46 EDT 
Hi, I had exactly the same problem, but just when using SSL and IE. Please see the full story here: http://www.eclipse.org/forums/index.php/t/369244/

The integration of the patch had saved me days of frustration, so I think this patch should be included.
If Cole is not present here anymore, I will try to add some test in the next weeks. But I've never contributed to an eclipse project :-)
Comment 3 Cole Markham CLA 2012-10-05 13:38:44 EDT 
Ralf, if I get some unit tests written for this, is it something we could get included into RAP 1.5 maintenance release or will it have to wait for 2.0?
Comment 4 Ralf Sternberg CLA 2012-10-18 11:10:29 EDT 
(In reply to comment #3)
> Ralf, if I get some unit tests written for this, is it something we could get
> included into RAP 1.5 maintenance release or will it have to wait for 2.0?

I think this issue is severe enough to include it in RAP 1.5.2.
Comment 5 Ivan Furnadjiev CLA 2012-11-05 06:52:10 EST 
Applied patch with some modifications with commit a86e839743d5f063b4f6b207d9027cef0d278a60. Added some new tests and fixed existing.
Comment 6 Ivan Furnadjiev CLA 2012-11-05 06:54:12 EST 
For the record: Fixed the same issue with the custom cursors too.
Comment 7 Stefan Klaus CLA 2013-03-01 09:11:56 EST 
As Ralf mentioned before this bug should be fixed in 1.5.2!
Is it fixed in 1.5.2?
Comment 8 Ivan Furnadjiev CLA 2013-03-01 09:30:31 EST 
(In reply to comment #7)
> As Ralf mentioned before this bug should be fixed in 1.5.2!
> Is it fixed in 1.5.2?

Unfortunately not.