Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362888 - [spell checking] New words for spelling check
Summary: [spell checking] New words for spelling check
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Matthias Mailänder CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 365782 384721 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-04 07:02 EDT by Lars Vogel CLA
Modified: 2013-10-21 07:13 EDT (History)
10 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2011-11-04 07:02:13 EDT
Please add the following word(s) to the JDT spell check:

+screenshot
+screenshots
Comment 1 Lars Vogel CLA 2011-11-04 10:14:43 EDT
+Evangelist
Comment 2 Lars Vogel CLA 2011-11-06 17:08:32 EST
+handsets
Comment 3 Lars Vogel CLA 2011-11-07 06:00:16 EST
+programmatically
Comment 4 Elias Volanakis CLA 2011-11-08 03:59:44 EST
+Apache
Comment 5 Lars Vogel CLA 2011-11-09 06:38:06 EST
+Acknowledgement
Comment 6 Lars Vogel CLA 2011-11-10 10:03:30 EST
+offline
Comment 7 Dani Megert CLA 2011-12-07 03:07:41 EST
*** Bug 365782 has been marked as a duplicate of this bug. ***
Comment 8 Lars Vogel CLA 2011-12-07 03:41:40 EST
+idempotent
Comment 9 Markus Kuppe CLA 2012-01-14 10:44:05 EST
+fingerprint
Comment 10 Markus Kuppe CLA 2012-01-17 17:28:48 EST
+iff
Comment 11 Wim Jongman CLA 2012-01-19 13:33:06 EST
+committer
Comment 12 Wim Jongman CLA 2012-01-20 09:40:07 EST
+ persistable
+ mime
Comment 13 Lars Vogel CLA 2012-01-31 11:37:59 EST
+Externalize
Comment 14 Markus Kuppe CLA 2012-01-31 13:43:57 EST
+malformed
Comment 15 Wim Jongman CLA 2012-02-02 06:21:01 EST
+ Euro
+ licensor
+ compliancy
+ (force) majeure
+ pursuance
Comment 16 Elias Volanakis CLA 2012-02-03 21:46:13 EST
+Uncheck
+uncheck
Comment 17 Elias Volanakis CLA 2012-02-03 22:05:20 EST
+png
+jpg
+gif
+apps
Comment 18 Lars Vogel CLA 2012-05-14 16:50:38 EDT
@Dani: Any change that you bring these words in for Eclipse 4.2 / 3.8? I see no target milestone.
Comment 19 Dani Megert CLA 2012-05-21 12:09:50 EDT
(In reply to comment #18)
> @Dani: Any change that you bring these words in for Eclipse 4.2 / 3.8? I see no
> target milestone.

Obviously things like "png" don't qualify, so I have to check each entry in this bug and currently I'm busy with much more important things.
Comment 20 Dani Megert CLA 2012-05-21 12:11:38 EDT
If it is important for you, then please check each entry against:

For British English: http://www.macmillandictionary.com/dictionary/british
For American English: http://www.merriam-webster.com/dictionary

and provide a list of valid words or even better, a patch.
Comment 21 Lars Vogel CLA 2012-06-02 14:57:03 EDT
+compliant

@Dani: which plugin & file do I need to patch?
Comment 22 Dani Megert CLA 2012-06-04 02:57:04 EDT
(In reply to comment #21)
> +compliant
> 
> @Dani: which plugin & file do I need to patch?

/org.eclipse.jdt.ui/dictionaries
Comment 23 Dani Megert CLA 2012-07-16 08:31:57 EDT
*** Bug 384721 has been marked as a duplicate of this bug. ***
Comment 24 Lars Vogel CLA 2012-10-09 04:44:41 EDT
+buildable
+reusable
Comment 25 Lars Vogel CLA 2013-06-11 11:00:43 EDT
+Creational
+orientated
Comment 26 Dani Megert CLA 2013-06-12 02:45:55 EDT
(In reply to comment #25)
> +Creational
> +orientated

Ple(In reply to comment #25)
> +Creational
> +orientated

Please see comment 20.
Comment 27 Lars Vogel CLA 2013-06-12 03:53:56 EDT
> Please see comment 20.

The comment is not forgotten, I still collect words in this bug report as I notice them. At some point in the future I will to do the check and provide a patch.
Comment 28 Lars Vogel CLA 2013-06-17 15:34:00 EDT
+versioning
Comment 29 Lars Vogel CLA 2013-07-31 05:10:30 EDT
+Lifecycle
Comment 30 Lars Vogel CLA 2013-08-01 05:16:46 EDT
Once we have Gerrit for JDT UI, see Bug 414105, I plans to use this bug as a test case.
Comment 31 Nitin Dahyabhai CLA 2013-08-20 11:23:00 EDT
+rectify
Comment 32 Timo Kinnunen CLA 2013-08-20 13:40:41 EDT
+refactor
+quad
+colorspace
+int
+viewport
+orthographic
+uncomment
+teleport
+teapot
+classpath
Comment 33 Matthias Mailänder CLA 2013-08-24 12:51:13 EDT
Submitted a patch at https://git.eclipse.org/r/15830 with words proposed here (except abbreviations) checked against http://dict.leo.org/
Comment 34 Dani Megert CLA 2013-08-25 11:27:54 EDT
(In reply to comment #33)
> Submitted a patch at https://git.eclipse.org/r/15830 with words proposed
> here (except abbreviations) checked against http://dict.leo.org/

Please see bug 362888 comment 20.
Comment 35 Timo Kinnunen CLA 2013-08-26 04:46:13 EDT
In the process of going over the words I found more words that are not recognized by the spell-checker. I have included them below as well.

Acknowledgment = the act of acknowledging / something that you say or do in order to show that you accept that something exists or is true
Apache = a member of a group of American Indian peoples of the southwestern United States  / no British definition
southwestern = lying toward or coming from the southwest / in or from the south-west of a country or region
southwest = to, toward, or in the southwest  / the direction that is between south and west. The south-west is the part of a country that is in this direction.
Euro = the common basic monetary unit of most countries of the European Union / the unit of money that is used in most countries in the European Union. Its symbol is €.
buildable = suitable for building; especially : capable of being built / a machine, vehicle, or other structure that is made by putting its parts together (derived from build (transitive))
committer = a person from whom a charge or trust is committed (derived from committee) / someone who gives someone or something to someone else to look after (derived from commit (formal))
compliancy = compliance / no British definition
creational = N/A / done or used for creating something (derived from recreational, recreation and creation) 
evangelist = N/A / a member of an evangelical church
evangelical = N/A / relating to a form of Christianity in which church services are very lively and people express their religious beliefs in an open and enthusiastic way
Christianity = N/A / the religion based on the ideas of Jesus Christ. Its followers worship in a church.
Jesus Christ = N/A / the man on whose ideas Christianity is based. Christians believe he was the son of God. He is often simply called Jesus or Christ.
fingerprint = N/A / a mark that you leave on something when you touch it, showing the pattern of lines on the skin of your fingers
handsets, handset = N/A / the part of a telephone that you hold next to your ear
idempotent = relating to or being a mathematical quantity which when applied to itself under a given binary operation (as multiplication) equals itself / no British definition
iff = N/A / a word used in mathematics and logic meaning 'if and only if'
int = N/A / internal
licensor = licenser / no British definition
(force) majeure = N/A / an unexpected event that stops you doing something that you promised to do in a contract
malformed = N/A / badly formed or shaped
mime = N/A / to tell a story or express yourself without words, using only the movements of your body and face
offline = N/A / not directly connected to a computer
orientated = N/A / oriented, mainly concerned with, or directed towards, a particular group, activity, or situation
persistable = N/A / being able to continue to do or say something in a determined way (derived from persist)
programmatically = N/A / happening or done according to a plan (derived from programmatic, as an adverb)
pursuance = N/A / in order to achieve an aim
quad = N/A / a quadruplet
quadruplet = N/A / a baby who is born at the same time as three other babies to the same mother
rectify = N/A / to correct a problem or mistake, or to make a bad situation better
refactor = N/A / to factorize a number again (derived from factor (verb))
factorize = to divide a number exactly into smaller numbers that can be multiplied together to make the original number
teapot = N/A / a container with a handle and a spout  (=small tube for pouring), used for making and pouring tea
teleport = N/A / to send people and objects very quickly from one place to another in the form of energy or signals. Some people believe this may be possible in the future.
throwable = N/A / a game or competition that can be deliberately lost (derived from throw, as an adjective)
uncheck = N/A / to no longer stop yourself or someone else from doing something (derived from check (transitive))
versioning = N/A / creating a form of something that is different from other forms or from the original (derived from version, mention and mentioning)
externalize = to make external or externally manifest / to express feelings and thoughts
orthographic = of, relating to, being, or prepared by orthographic projection / no British definition

These don't have a general dictionary definition, but they are defined within the broad field of computer sciences:
viewport = refers to one specific piece in a system related to 3D computer graphics.
uncomment = performing a specific programming language source code change in a text editor.
classpath = the name of a Java-specific programming environment feature.

These are alternate versions:
colorspace = color space
lifecycle = life cycle
Comment 36 Lars Vogel CLA 2013-08-26 13:22:33 EDT
@Time, Dani defined the criteria for inclusion in Comment 20 and AFAIK this is not open for discussion. I personally also agree with the approach of using official dictionaries. This helps to avoid lengthy discussions about if a word should be included or not. 

@Matthias, I suggest you check the words we collected so gar against the online dictionaries and report "invalid" words in this bug after updating the review.
Comment 37 Timo Kinnunen CLA 2013-08-27 11:15:20 EDT
Lars, what I listed was the definition found by checking each word ('entry') against merriam-webster.com and macmillandictionary.com dictionaries, respectively. M-W was behind a paywall for most of the time; those were marked N/A. If 'valid word' is taken to mean a word that someone who understands English but isn't familiar with that word can find a definition for using one of the dictionaries, then the 1st list in comment 35 is a list of such words and their definitions. 

However, that would still leave the spell checker marking the word "classpath" - used in several places within the Eclipse IDE itself - as spelled wrong. Maybe a new bug should be opened for that one?
Comment 38 Lars Vogel CLA 2013-08-27 12:36:54 EDT
Timo, I re-checked "committer" in both directories and they returned that this word is unknown. What did you do different?
Comment 39 Timo Kinnunen CLA 2013-08-28 22:07:14 EDT
I did what someone who is using a dictionary to check the meaning of a word would do if the dictionary didn't have that particular variation of it: I didn't give up but looked at the similar words that were suggested.

I'll retrace my steps:

Merriam-Websters: the word committee is suggested in a dropdown list when you type in the word committer. The first definition for the word committee is "archaic : a person to whom a charge or trust is committed". Employee is to employer as committee is to committer, ergo committer is a person from whom a charge or trust is committed.

Macmillan: the word committed is the first suggestion in the "Did you mean" list when you search for committer. The definition page for committed contains a "related dictionary definitions" section with a link to "commit, verb". One of the definitions of commit is "to give someone or something to someone else to look after". A writer is someone who writes, ergo a committer is someone who gives someone or something to someone else to look after.

It's remarkable how close to the correct definition both of those are despite coming from different dictionaries that are in no way geared towards IT terminology. I guess it empirically proves that this manner of checking a word is proper and valid.
Comment 40 Lars Vogel CLA 2013-08-29 12:58:39 EDT
(In reply to comment #39)
> I did what someone who is using a dictionary to check the meaning of a word
> would do if the dictionary didn't have that particular variation of it: I
> didn't give up but looked at the similar words that were suggested.

@Dani, is this in line with your acceptance criteria?
Comment 41 Dani Megert CLA 2013-08-30 07:10:43 EDT
(In reply to comment #40)
> (In reply to comment #39)
> > I did what someone who is using a dictionary to check the meaning of a word
> > would do if the dictionary didn't have that particular variation of it: I
> > didn't give up but looked at the similar words that were suggested.
> 
> @Dani, is this in line with your acceptance criteria?

If the argumentation would be correct, then the word would be in the dictionary ;-). I want to keep a clear rules.
Comment 42 Timo Kinnunen CLA 2013-08-31 07:08:10 EDT
I don't know what criteria the maintainers of dictionaries use to decide which word forms to add and when, but I know me having to workaround few missing derivative words is not the deciding factor. Oxford English Dictionary at oxforddictionaries.com recognizes the word *committer* as a noun derivative from the verb commit so it seems there are no generalizations to be drawn here. The difference could be just in a conscious decision to make your dictionary that much more easy to use and then doing it.

Of the word *versioning*, Oxford's American-English definition says: "

version 
verb  [with object] (often as noun versioning)
create a new version of:

it’s the software for you if you need versioning and group editing"

Now that's how one exceeds expectations and goes to set the example for others to strive for.
Comment 43 Matthias Mailänder CLA 2013-09-02 15:43:03 EDT
Getting back to https://git.eclipse.org/r/15830 I simply check the words I added against those well known dictionary publisher instead of http://dict.leo.org/ (a project run by the Technical University of Munich, Computer Science Department that is very popular in Germany) to get merged?
Comment 44 Lars Vogel CLA 2013-09-03 04:31:52 EDT
@Matthias, yes. I suggest you create a little spreadsheet (maybe an Google doc which can be later exported as .cvs file and attached to this bug) which contain your checks. 

As format I suggest:

Word         Macmillandictionary   Merriam-webster  comment
screenshot   Yes                   Yes
screenshots  Yes                   Yes
Evangelist   Yes                   Yes
handsets     No                    No
handset      Yes                   Yes              added because handsets failed

etc.

After we have the data, you can update your Gerrit review patch.

And once we have done this work, Dani could apply the patch (if he trusts us) or check the words again (if we does not) ;-)
Comment 45 Matthias Mailänder CLA 2013-09-28 10:57:09 EDT
Here we go https://docs.google.com/spreadsheet/pub?key=0ApPX-BsqgwegdEtSX1JLc0lDQ1B2Q1I2Y2hfbHFmZnc&output=html I used only dictionaries by reliable well-known publishers except Merriam Webster because for the 14 days trial triggered after several searches they want your credit card number.
Comment 46 Lars Vogel CLA 2013-09-30 05:03:38 EDT
@Matthias, could you add the links for Apache? It looks to me that it is contained in the official dictionaries?

@Dani, are you ok with a Gerrit review for the green entries in the spreadsheet?
Comment 47 Dani Megert CLA 2013-10-01 06:44:09 EDT
(In reply to Matthias Mailänder from comment #45)
> Merriam Webster because for the 14
> days trial triggered after several searches they want your credit card
> number.

I've never seen this in years.
Comment 48 Dani Megert CLA 2013-10-01 06:44:58 EDT
(In reply to Lars Vogel from comment #46)
> @Dani, are you ok with a Gerrit review for the green entries in the
> spreadsheet?

Yes, if they follow the rules ;-).
Comment 49 Lars Vogel CLA 2013-10-01 07:51:31 EDT
> I've never seen this in years. 

Maybe you never checked a lot of words in the same session. 

> Yes, if they follow the rules ;-).

The rules seems to require a credit card, which I hope invalidates that rule. 	Are you ok with http://dictionary.cambridge.org/dictionary/british/ as new checker?
Comment 50 Dani Megert CLA 2013-10-01 08:30:08 EDT
(In reply to Lars Vogel from comment #49)
> > I've never seen this in years. 
> 
> Maybe you never checked a lot of words in the same session. 

Possibly, but for earlier requests I used in several times in a row without problems. Maybe they changed it in the meantime.

 
> > Yes, if they follow the rules ;-).
> 
> The rules seems to require a credit card, which I hope invalidates that
> rule. 	Are you ok with http://dictionary.cambridge.org/dictionary/british/
> as new checker?

Sounds wrong, given we use Merriam Webster for AMERICAN English. I don't have time to evaluate a new dictionary at this point. If you are confident with the words, you can prepare a patch and I will sanity check some of the entries. If they pass, I'll accept the change.
Comment 51 Lars Vogel CLA 2013-10-01 08:39:30 EDT
> Sounds wrong, given we use Merriam Webster for AMERICAN English. I don't
> have time to evaluate a new dictionary at this point. 

oxforddictionaries.com has also English:
http://oxforddictionaries.com/definition/american_english/

>  If you are confident with the words, you can prepare a patch

@Matthias, sounds good. Please create a Gerrit review for Dani.
Comment 52 Matthias Mailänder CLA 2013-10-06 11:27:40 EDT
See https://git.eclipse.org/r/#/c/17076/
Comment 53 Dani Megert CLA 2013-10-08 07:07:18 EDT
(In reply to Matthias Mailänder from comment #52)
> See https://git.eclipse.org/r/#/c/17076/

Thanks. The change is almost good. See my comments there.
Comment 54 Matthias Mailänder CLA 2013-10-12 12:46:00 EDT
I updated https://git.eclipse.org/r/#/c/17076/ Sorry for the change commit spam. I am just getting used to EGit and Gerrit.
Comment 56 Lars Vogel CLA 2013-10-14 06:59:42 EDT
Thanks Dani and Matthias!
Comment 57 Paul Benedict CLA 2013-10-17 11:19:56 EDT
+proxies
Comment 58 Dani Megert CLA 2013-10-18 03:45:56 EDT
(In reply to Paul Benedict from comment #57)
> +proxies

This bug here is closed, so adding new words here won't help.
Comment 59 Paul Benedict CLA 2013-10-18 13:19:00 EDT
Dani, is this the only ticket that's ever going to add dictionary words for 4.4? My opinion is to keep this ticket open until RC1 so other words can be added.
Comment 60 Dani Megert CLA 2013-10-21 07:13:10 EDT
(In reply to Paul Benedict from comment #59)
> Dani, is this the only ticket that's ever going to add dictionary words for
> 4.4? My opinion is to keep this ticket open until RC1 so other words can be
> added.

We can collect more words in a new bug. Once a patch is ready and released, I want the bug to be closed. That's easier to track.