Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362809 - Build final content.jar is deleted by validation
Summary: Build final content.jar is deleted by validation
Status: CLOSED FIXED
Alias: None
Product: CBI
Classification: Technology
Component: CBI p2 Repository Aggregator (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 352995 362963 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-03 11:44 EDT by Miles Daffin CLA
Modified: 2016-09-16 15:52 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Daffin CLA 2011-11-03 11:44:13 EDT
Build Identifier: I20110613-1736

If I run a successful build and then run validate again the content.jar is deleted. I would not expect anything in the build/final directory to be touched by a validation pass. If I then try to regenerate content.jar by running build again I get the following error:

java.lang.ClassCastException: org.eclipse.equinox.internal.p2.artifact.repository.CompositeArtifactRepository cannot be cast to org.eclipse.equinox.p2.repository.artifact.IFileArtifactRepository
	at org.eclipse.b3.aggregator.engine.Builder.getAggregationArtifactRepository(Builder.java:730)
	at org.eclipse.b3.aggregator.engine.Builder.initializeArtifactMirroring(Builder.java:1004)
	at org.eclipse.b3.aggregator.engine.Builder.run(Builder.java:1650)
	at org.eclipse.b3.aggregator.presentation.AggregatorActionBarContributor$BuildAggregationAction$1.run(AggregatorActionBarContributor.java:292)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

If I run the build again it does not fail, but the metadata can sometimes be broken.

Reproducible: Always

Steps to Reproduce:
1. Run a repo build and wait for it to complete successfully
2. Validate the model
3. Check if content.jar is present (should not be)
4. Run a build again - get CCE.
Comment 1 Thomas Hallgren CLA 2011-11-05 07:47:38 EDT
*** Bug 362963 has been marked as a duplicate of this bug. ***
Comment 2 Miles Daffin CLA 2011-11-11 15:01:55 EST
IMO Validation should not mess with the final build output. Currently deletes stuff, e.g. content.jar. Thomas H. agrees this is wrong.
Comment 3 Thomas Hallgren CLA 2011-11-12 03:59:19 EST
*** Bug 352995 has been marked as a duplicate of this bug. ***
Comment 5 Miles Daffin CLA 2011-11-14 10:20:38 EST
I can confirm that validation does not now alter the final build output directory in any way. Thanks. Closing.
Comment 6 David Williams CLA 2016-09-16 15:52:01 EDT
[Bookkeeping change only. Moving bugs to the new "home" of aggregator, CBI.
Made no changes to assignee's for closed bugs, even though some were old inbox.]