Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362761 - Create new project need to be faster and cleaner
Summary: Create new project need to be faster and cleaner
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Xiao Bin Chen CLA
QA Contact: Will Smythe CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-03 02:13 EDT by Tony Chen CLA
Modified: 2017-02-23 14:17 EST (History)
3 users (show)

See Also:


Attachments
compiling starts before wizard is closed (62.03 KB, image/gif)
2012-01-16 03:10 EST, Tony Chen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chen CLA 2011-11-03 02:13:13 EDT
M3 Feedback:
Enhancement: the creation of a new 'RUI' project is still slow and numerous dialogs appear and go away during the Finish process. In general, no workspace operations (i.e. build) should be happening until everything has been added to / configured in the workspace. All building should happen after the wizard goes away, not while the wizard is still open ...
Comment 1 Xiao Bin Chen CLA 2011-12-16 00:06:09 EST
Fixed.
Don't know if nightly build works now.
If it does,please update to the current nightly build. and verify it.


In the fix:The progress status of importing action of rui widget and dojowidet project(zipfile) could be represent rightly in the status bar.

And after the new fix, the spending time of create rui project will be much reduced. I test it in my machine. About 10s could create a new rui project.

I think it's much better now.

Any problem, please reopen it.

Thanks 
xiaobin.
Comment 2 Tony Chen CLA 2012-01-16 03:09:56 EST
I tested with Version: 0.8.0.v201201152102-1CT-Fiv5_M5_LOR6Ka4. 

Compiling will not begin until all imports are completed. Great!
Progress (for importing dojo widgets) looks reasonable. Great!

Still seeing some problems
1. Small progress popup window will appear and go several times, can we not show these windows? 
2. I tested about 10 times, and twice I saw the compiling started without the wizard being closed. The 'finish' button on the wizard is disabled, so I could not do anything until compiling finishes. I'll attach a screenshot. 

I reopened the bug to the 2 problems described above. 


In my desktop machine, creating a rui prj with importing both widget projects takes 40 seconds. Creating a rui prj with widget project already in workspace takes 3 seconds which looks good to me. The 40 seconds, mostly is spent importing the Dojo widget projects, which contains a lot of js and resource files. We should further explore how to reduce the number of resource in the dojo widget project. But that should be a separate bug/enhancement. 



(In reply to comment #1)
> Fixed.
> Don't know if nightly build works now.
> If it does,please update to the current nightly build. and verify it.
> 
> 
> In the fix:The progress status of importing action of rui widget and dojowidet
> project(zipfile) could be represent rightly in the status bar.
> 
> And after the new fix, the spending time of create rui project will be much
> reduced. I test it in my machine. About 10s could create a new rui project.
> 
> I think it's much better now.
> 
> Any problem, please reopen it.
> 
> Thanks 
> xiaobin.
Comment 3 Tony Chen CLA 2012-01-16 03:10:54 EST
Created attachment 209527 [details]
compiling starts before wizard is closed
Comment 4 Xiao Bin Chen CLA 2012-01-17 22:32:45 EST
Fixed.

1>Currently,To avoid a lot of window pop up I put those cost less time operation together into one operation.These operation include:

ProjectCreationOperation
ProjectConfigurationOperation
ProjectGeneratorOperation
FeatureOperation(some of feature for egl project which will be get from EGLProjectFeatureContributionsRegistry)
etc...
About ten operations so far.

To make import rui dojo sample wizard .zip progress bar more precise I put each .zip import action into one operation. And make the progress clear and accurate.

2>To make sure workspace building will not start before the project creation wizard end.
I put import action at the end and set these operation run as blocking mode.So the workspace building action will only beginning after these importing actions finished.
Comment 5 Tony Chen CLA 2012-01-18 03:59:06 EST
Will, can you please verify this enhancement since it comes from your feedback for M3.
Comment 6 Tony Chen CLA 2012-01-18 22:39:01 EST
Verified that the problem in comment 2 is fixed in Version: 0.8.0.v201201182111-1CT-Fiv5_M5_LQk6LLJ

Creating new project looks good to me now. Importing dojo widgets still takes too much time compared with other activities during creation of a new project. This issues will be addressed in Bug 364415 - Investigate being smarter about what Dojo files need to get deployed
Comment 7 lu lu CLA 2012-02-29 21:49:46 EST
(In reply to comment #6)
> Verified that the problem in comment 2 is fixed in Version:
> 0.8.0.v201201182111-1CT-Fiv5_M5_LQk6LLJ
> 
> Creating new project looks good to me now. Importing dojo widgets still takes
> too much time compared with other activities during creation of a new project.
> This issues will be addressed in Bug 364415 - Investigate being smarter about
> what Dojo files need to get deployed


Verified in build 0.8.0.v201202280901 again, works now. 

And about Bug 364415, it will be resolved and delivered while upgrading to Dojo 1.7.1. :-)
Comment 8 Lisa Lasher CLA 2012-03-30 17:53:02 EDT
close