Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362655 - SimpleNamesFragment incorrect/not updated
Summary: SimpleNamesFragment incorrect/not updated
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 363022 363179 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-02 07:32 EDT by Meinte Boersma CLA
Modified: 2017-09-19 17:14 EDT (History)
5 users (show)

See Also:
sven.efftinge: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Meinte Boersma CLA 2011-11-02 07:32:22 EDT 
Build Identifier: M20110909-1335

The SimpleNamesFragment binds org.eclipse.xtext.ui.refactoring.IDependentElementsCalculator to org.eclipse.xtext.ui.refactoring.IDependentElementsCalculator.Null, but the latter one doesn't exist anymore. In fact, the default implementation (through Guice annotations) is DefaultDependentElementsCalculator, so the explicit binding could be left out. If left in, the binding target should be DefaultDependentElementsCalculator, just as the QualifiedNamesFragment does.

(You guys should really have some test case with the SimpleNamesFragment - not everyone only builds JVM languages with fully qualified names ;))

Reproducible: Always

Steps to Reproduce:
1. see details
2.
3.
Comment 1 Sebastian Zarnekow CLA 2011-11-07 04:46:42 EST 
*** Bug 363022 has been marked as a duplicate of this bug. ***
Comment 2 Sven Efftinge CLA 2011-11-07 15:00:32 EST 
pushed to master
Comment 3 Sebastian Zarnekow CLA 2011-11-08 09:57:21 EST 
*** Bug 363179 has been marked as a duplicate of this bug. ***
Comment 4 Karsten Thoms CLA 2017-09-19 17:02:41 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 17:14:11 EDT 
Closing all bugs that were set to RESOLVED before Neon.0