Community
Participate
Working Groups
The new Bidi processors rapidly approaching point at which they can be opened for general use by the Eclipse SDK and its consumers (bug 183164). It seems like this is a good time to add them to the build & test. The bundles are: org.eclipse.equinox.bidi org.eclipse.equinox.bidi.tests from the Git repo rt.equinox.bundles\bundles. Tom suggested that the Bidi bundle could be added to the org.eclipse.rcp feature. The bundles probably have to be added to a map file, I am not sure if rcp.map or core.map make more sense. Also it would be nice to have JUnits from the test bundle (STextTestSuite) being incorporated into the regular Eclipse tests.
(In reply to comment #0) > The new Bidi processors rapidly approaching point at which they can be opened > for general use by the Eclipse SDK and its consumers (bug 183164). > > It seems like this is a good time to add them to the build & test. > > The bundles are: > > org.eclipse.equinox.bidi > org.eclipse.equinox.bidi.tests > > from the Git repo rt.equinox.bundles\bundles. > > Tom suggested that the Bidi bundle could be added to the org.eclipse.rcp > feature. I think this makes sense if we think other bundles in the RCP feature will actually use the new bidi bundles. If nothing from the Eclipse SDK will use the new bidi bundles in Juno then perhaps this is only part of some equinox specific feature. > > The bundles probably have to be added to a map file, I am not sure if rcp.map > or core.map make more sense. core.map is where it goes along with the rest of the equinox bundles (except p2). At some point we really should split the equinox bundles in core.map out into a separate equinox.map file. > > Also it would be nice to have JUnits from the test bundle (STextTestSuite) > being incorporated into the regular Eclipse tests.
So where should this be added? To the RCP feature or an equinox specific feature?
We don't want to consume this in the org.eclipse.rcp feature in 3.8/4.2, as no one uses it. Can we make this consumable from an equinox feature so that it could be installed easily? PW
OK, quick reversal of position :-) I would like this in the rcp feature. We have some patches pending from the contributor that can fix SDK bugs, using the new API. PW
(In reply to comment #2) > So where should this be added? To the RCP feature or an equinox specific > feature? I think it should be added to RCP. It also should be added to rt.equinox.framework/features/org.eclipse.equinox.core.sdk/ equinox feature.
Oleg, can you please update the map files to include these new bundles? I'll update the feature and run a test build. Are the bidi.tests run against the SDK?
(In reply to comment #6) > Oleg, can you please update the map files to include these new bundles? I'll > update the feature and run a test build. I've tried to manually tag the bundles but it did not seem like tags got pushed by EGit and doing manually I get: $ git push origin :refs/tags/v20111108-1400 Password: remote: warning: Allowing deletion of corrupt ref. To ssh://obesedin@git.eclipse.org/gitroot/equinox/rt.equinox.bundles.git - [deleted] v20111108-1400 > Are the bidi.tests run against the SDK? They can be run in a headless mode.
The bidi.tests bundle needs a test.xml so the tests can run against the SDK, currently that is missing.
Oleg/Tom I'm getting rejected from pushing the changes to the equinox.core.sdk. An error about commit rights. Anyways can you add this to the equinox.core.sdk's feature.xml <plugin id="org.eclipse.equinox.bidi" download-size="0" install-size="0" version="0.0.0" unpack="false"/> <plugin id="org.eclipse.equinox.bidi.source" download-size="0" install-size="0" version="0.0.0" unpack="false"/> and the following to it's build.properties generate.plugin@org.eclipse.equinox.bidi.source.source=org.eclipse.equinox.bidi thanks
(In reply to comment #7) > (In reply to comment #6) > > Oleg, can you please update the map files to include these new bundles? I'll > > update the feature and run a test build. > > I've tried to manually tag the bundles but it did not seem like tags got pushed > by EGit and doing manually I get: I personally only tag from command line. > > $ git push origin :refs/tags/v20111108-1400 > Password: > remote: warning: Allowing deletion of corrupt ref. > To ssh://obesedin@git.eclipse.org/gitroot/equinox/rt.equinox.bundles.git > - [deleted] v20111108-1400 The command you ran tries to delete the non-existing tag! git push --tags will push your local tags upstream. > > > Are the bidi.tests run against the SDK? > > They can be run in a headless mode.
(In reply to comment #9) > Oleg/Tom > > I'm getting rejected from pushing the changes to the equinox.core.sdk. An > error about commit rights. Did you open a bug against the foundation on this? > Anyways can you add this to the equinox.core.sdk's > feature.xml > > <plugin > id="org.eclipse.equinox.bidi" > download-size="0" > install-size="0" > version="0.0.0" > unpack="false"/> > > > <plugin > id="org.eclipse.equinox.bidi.source" > download-size="0" > install-size="0" > version="0.0.0" > unpack="false"/> > > and the following to it's build.properties > generate.plugin@org.eclipse.equinox.bidi.source.source=org.eclipse.equinox.bidi > > thanks No problem, done.
I tagged the latest commit of the rt.equinox.bundles repo with the tag v20111108-1700 and updated the core.map for the bidi bundles to use this tag.
The bidi binary and source bundles are in the N20111108-2000. If you add a test.xml to the bidi.tests bundle I can enable the build to run the associated tests.
Created attachment 206679 [details] patch
I added plugin.xml, tagged bundles as v20111109-1000 and updated map file. (In reply to comment #10) > (In reply to comment #7) > The command you ran tries to delete the non-existing tag! git push --tags will > push your local tags upstream. Thanks! That worked.
(In reply to comment #15) > I added plugin.xml => That is "test.xml".
Created attachment 206730 [details] patch
Okay bidi tests have been added and a test build was successful. Tagged and released for i-build.
