Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362517 - [OCLinEcore] Loading Ecore.ecore takes forever
Summary: [OCLinEcore] Loading Ecore.ecore takes forever
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: OCL Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 363894
Blocks:
  Show dependency tree
 
Reported: 2011-10-31 13:23 EDT by Ed Willink CLA
Modified: 2013-05-20 11:36 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-10-31 13:23:56 EDT
Since switching to the new Xtext serializer, the save asdsopciated with a load of Ecore.ecore or UML.ecore takes forver.

a) file an Xtext bug with a repro.

b) find out why no JUnit test detects this.
Comment 1 Ed Willink CLA 2011-11-12 13:00:41 EST
There appear to be at least three problems

The CS 2 Pivot conversion cannot handle the type Wildcard in "attribute instanceClass : EJavaClass<?>[?]" giving an IAE.

The subsequent CS analysis shows numerous proxy errors since the CS 2 PIvot conversion was aborted.

These proxy errors then causes the serialization to barf.
Comment 2 Ed Willink CLA 2011-11-15 14:26:56 EST
(In reply to comment #0)
> b) find out why no JUnit test detects this.

Because there is no LoadTests for Ecore.ecore.
Comment 3 Ed Willink CLA 2011-11-16 01:28:18 EST
(In reply to comment #0)
> a) file an Xtext bug with a repro.

Bug 363894.

(In reply to comment #1)
> There appear to be at least three problems
> 
> The CS 2 Pivot conversion cannot handle the type Wildcard in "attribute
> instanceClass : EJavaClass<?>[?]" giving an IAE.

The order of processing when opening a *.ecore for text edit is.
a) Ecore to Pivot
b) Pivot to CS
c) CS to text
d) text to CS

the serializer locks up in c).

the wildcard parsing difficulties are in d) and so are not relevant to the serializer problem.
Comment 4 Ed Willink CLA 2012-03-27 06:46:26 EDT
(In reply to comment #3) 
> the wildcard parsing difficulties are in d) and so are not relevant to the
> serializer problem.

If instrumentation is added with a toString() the wildcard problem shows up in a). There is a TemplateBindingCS with a null pivot.
Comment 5 Ed Willink CLA 2012-04-04 06:31:17 EDT
Xtext serializer problem fixed.

NPE while debugging avoided.

Premature conversion of exceptions in CS2Pivot fixed.

Tests work.
Comment 6 Ed Willink CLA 2013-05-20 11:36:54 EDT
CLOSED after a year in the RESOLVED state.