Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362515 - Resource#contains and #isConflicting should check if the other resource is stored in the same workspace
Summary: Resource#contains and #isConflicting should check if the other resource is st...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Szymon Ptaszkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 12:56 EDT by Szymon Ptaszkiewicz CLA
Modified: 2011-11-04 07:44 EDT (History)
2 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2011-11-01 08:51 EDT, Szymon Ptaszkiewicz CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2011-10-31 12:56:39 EDT 
While working on bug 362227 it turned out that Resource#contains and Resource#isConflicting do not check if the other resource is stored in the same workspace. This not a problem at the moment, but in case we add multi-workspace support, two resources with the same path stored within different workspaces would be in conflict with each other.
Comment 1 Szymon Ptaszkiewicz CLA 2011-11-01 08:51:47 EDT 
Created attachment 206263 [details]
Patch
Comment 2 Szymon Brandys CLA 2011-11-03 11:25:31 EDT 
Makes sense. Could you also write a test for it?
Comment 3 Szymon Brandys CLA 2011-11-04 06:07:09 EDT 
I assumed that the multi workspace work was merged into master. Check that the test pass and feel free to release the fix.
Comment 4 Szymon Ptaszkiewicz CLA 2011-11-04 07:44:07 EDT 
Thanks! Fixed in master.