Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362503 - Compare editor does not highlight comments
Summary: Compare editor does not highlight comments
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 11:32 EDT by Silenio Quarti CLA
Modified: 2011-12-01 17:00 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Silenio Quarti CLA 2011-10-31 11:32:01 EDT 
Open a side-by-side compare editor on a javascript file. Note that the comments are not highlighted.
Comment 1 Silenio Quarti CLA 2011-10-31 11:47:12 EDT 
The problem started happening because the "textstyler.css" changed but the copy "org.eclipse.orion.client.core/web/orion/compare/editor.css" was not updated. I fixed the problem for now by updating the copy.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e9dd25332ca359f4c39740b11f2daafff4ef118d

Libling, I believe the compare editor should not copy the stylesheets out of the editor. Currently it copies the styler, rulers and annotations style sheets.  The org.eclipse.orion.client.core/web/orion/compare/rulers.js file is also an out of date copy. We should work towards removing these copies and add the support you need in the default implementation of the rulers.